generate: Add temporal correlations to noise simulator#4487
Open
cwindolf wants to merge 6 commits intoSpikeInterface:mainfrom
Open
generate: Add temporal correlations to noise simulator#4487cwindolf wants to merge 6 commits intoSpikeInterface:mainfrom
cwindolf wants to merge 6 commits intoSpikeInterface:mainfrom
Conversation
Collaborator
Author
|
Sorry, I think my formatter has the wrong presets! Hopefully diff shrinks after pre commit bot. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 9877d07.
Collaborator
Author
|
Hmm, so I don't think there's a good way to do this without scipy, but core tests don't include scipy dependency. I'm wondering, is there another good place for me to put my unit test so that it will run with scipy? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4482
This adds temporal noise to the simulations. It is parametrized by a spectral density which the user would supply as a numpy array.
I added logic for circular padding to the generator class so that everything is still totally circular like in tile_pregenerated. This required moving the old get_traces() into a helper.
There's also a flag I ended up putting in to allow the user to turn on overlap-add convolutions. It's off by default, because it can introduce inconsistencies in the output if the user is not careful (in particular, the unit test I added will fail). But I think it's worth keeping this since it will be substantially faster when generating large noise simulations, and it's totally safe if one plans to just call save_to_folder() or something.