Skip to content

Fix quality curation when other labels are given by user #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alejoe91 merged 4 commits into from
Apr 1, 2026
Merged

Fix quality curation when other labels are given by user #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7c734ce
update channel visibility on unit change from unitview
chrishalcrow Mar 30, 2026
0ebdd27
Revert "update channel visibility on unit change from unitview"
chrishalcrow Mar 30, 2026
811b05b
change label check for v2 curation
chrishalcrow Mar 31, 2026
c9052e1
a couple of additional fixes
alejoe91 Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spikeinterface_gui/backend_panel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,8 @@ def set_external_curation(self, curation_data):

curation_view = self.views["curation"]
self.controller.set_curation_data(curation_data)
self.controller.current_curation_saved = True
curation_view.notify_manual_curation_updated()
self.controller.current_curation_saved = True
curation_view.refresh()

# we also need to refresh the unit list view to update the unit visibility according to the new curation
Expand Down
6 changes: 4 additions & 2 deletions spikeinterface_gui/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -900,7 +900,7 @@ def set_curation_data(self, curation_data):
new_curation_data["label_definitions"] = default_label_definitions.copy()

# validate the curation data
model = CurationModel(**new_curation_data)
model = Curation(**new_curation_data)
self.curation_data = model.model_dump()

def save_curation_in_analyzer(self):
Expand Down Expand Up @@ -1117,11 +1117,13 @@ def set_label_to_unit(self, unit_id, category, label):
if label is None:
self.remove_category_from_unit(unit_id, category)
return

label_types = self.curation_data['label_definitions'].keys()

ix = self.find_unit_in_manual_labels(unit_id)
if ix is not None:
lbl = self.curation_data["manual_labels"][ix]
if "labels" in lbl and category in lbl["labels"]:
if "labels" in lbl and category in label_types:
# v2 format
lbl["labels"][category] = [label]
elif category in lbl:
Expand Down
Loading