Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
205 changes: 205 additions & 0 deletions experimental/algorithm/LAGraph_CFL_Kron.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,205 @@
#include <LAGraphX.h>
#include <GraphBLAS.h>
#include <LAGraph.h>
#include <stdbool.h>
#include <stdlib.h>

typedef struct {
GrB_Index state_count;
GrB_Index terminal_count;
GrB_Index nonterminal_count;
GrB_Index start_nonterminal;
GrB_Matrix* terminal_matrices;
GrB_Matrix* nonterminal_matrices;
GrB_Index* start_states;
GrB_Vector* final_states;
} RSM;

#define LG_FREE_WORK \
{ \
GrB_free(&CombinedGraph); \
}

GrB_Info transitive_closure_inplace(GrB_Matrix A) {
GrB_Index n;
GrB_Matrix_ncols(&n, A);

GrB_Matrix Frontier = NULL;
GrB_Matrix NextFrontier = NULL;

GrB_Matrix_dup(&Frontier, A);
GrB_Matrix_new(&NextFrontier, GrB_BOOL, n, n);

while (true) {
GrB_Matrix_clear(NextFrontier);
GrB_mxm(NextFrontier, NULL, NULL, GxB_ANY_PAIR_BOOL, Frontier, A, NULL);
GrB_assign(Frontier, A, NULL, NextFrontier, GrB_ALL, n, GrB_ALL, n, GrB_DESC_RC);
GrB_Index frontier_nvals;
GrB_Matrix_nvals(&frontier_nvals, Frontier);
if (frontier_nvals == 0) break;
GrB_eWiseAdd(A, NULL, NULL, GrB_LOR, A, Frontier, NULL);
}

GrB_free(&Frontier);
GrB_free(&NextFrontier);
return GrB_SUCCESS;
}

GrB_Info LAGraph_CFL_AllPaths_Kronecker
(
GrB_Matrix *outputs,
const GrB_Matrix *adj_matrices,
int64_t terms_count,
RSM *rsm,
char *msg
)
{
GrB_Index g_dim;
GrB_Matrix_ncols(&g_dim, adj_matrices[0]);
GrB_Index r_dim = rsm->state_count;
GrB_Index kronecker_dim = r_dim * g_dim;

// Allocating memory for delta's (new paths from the previous iteration)
GrB_Matrix *delta_outputs = (GrB_Matrix *)malloc(rsm->nonterminal_count * sizeof(GrB_Matrix));
GrB_Matrix temp_output;
GrB_Matrix_new(&temp_output, GrB_BOOL, g_dim, g_dim);

for (int64_t nt = 0; nt < rsm->nonterminal_count; ++nt) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is hard to realize this loop. We iterate through all non-terminals. Each non-terminal must has related box and this box must has at least one final state. So, it is unclear what exactly we do in this loop.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right, that you just handle boxes where the same state is both final and start?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's it

GrB_Matrix_new(&outputs[nt], GrB_BOOL, g_dim, g_dim);
GrB_Matrix_new(&delta_outputs[nt], GrB_BOOL, g_dim, g_dim);

GrB_Index s = rsm->start_states[nt];
bool is_final = false;
GrB_Vector_extractElement_BOOL(&is_final, rsm->final_states[nt], s);

if (is_final) {
for (GrB_Index v = 0; v < g_dim; ++v) {
GrB_Matrix_setElement_BOOL(outputs[nt], true, v, v);
GrB_Matrix_setElement_BOOL(delta_outputs[nt], true, v, v);
}
}
}

GrB_Matrix BaseGraph = NULL;
GrB_Matrix M_graph = NULL;
GrB_Matrix CombinedGraph = NULL;
GrB_Matrix DeltaM = NULL;


GrB_Matrix_new(&M_graph, GrB_BOOL, kronecker_dim, kronecker_dim);

for (int64_t t = 0; t < terms_count; ++t) {
GrB_kronecker(M_graph, NULL, GrB_LOR, GxB_PAIR_BOOL,
rsm->terminal_matrices[t], adj_matrices[t], NULL);
}

GrB_Matrix_new(&BaseGraph, GrB_BOOL, kronecker_dim, kronecker_dim);
GrB_Matrix_new(&DeltaM, GrB_BOOL, kronecker_dim, kronecker_dim);

for (int64_t t = 0; t < terms_count; ++t) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Забыли почистить код? Что-то тут странное, начинач со строки 91

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Да, видимо когда менял код, продублировал этот цикл

GrB_kronecker(BaseGraph, NULL, GrB_LOR, GxB_PAIR_BOOL,
rsm->terminal_matrices[t], adj_matrices[t], NULL);
}

// M_graph will store the "raw" Kronecker edges (without closure)
GrB_Matrix_dup(&M_graph, BaseGraph);

GrB_Index max_finals = 0;
for (int64_t nt = 0; nt < rsm->nonterminal_count; ++nt) {
GrB_Index f_nvals = 0;
GrB_Vector_nvals(&f_nvals, rsm->final_states[nt]);
if (f_nvals > max_finals) max_finals = f_nvals;
}

GrB_Index *row_indices = (GrB_Index *)malloc(g_dim * sizeof(GrB_Index));
GrB_Index *col_indices = (GrB_Index *)malloc(g_dim * sizeof(GrB_Index));
GrB_Index *f_indices = (GrB_Index *)malloc((max_finals > 0 ? max_finals : 1) * sizeof(GrB_Index));
bool *f_values = (bool *)malloc((max_finals > 0 ? max_finals : 1) * sizeof(bool));

bool changed = true;
bool is_first_iteration = true;

while (changed) {
changed = false;
GrB_Matrix_clear(DeltaM);

// Incremental addition of non-terminals
bool has_new_edges = false;
for (int64_t nt = 0; nt < rsm->nonterminal_count; ++nt) {
GrB_Index delta_vals;
GrB_Matrix_nvals(&delta_vals, delta_outputs[nt]);
if (delta_vals > 0) {
has_new_edges = true;
GrB_kronecker(DeltaM, NULL, GrB_LOR, GxB_PAIR_BOOL,
rsm->nonterminal_matrices[nt], delta_outputs[nt], NULL);
}
}

if (!has_new_edges && !is_first_iteration) break;

if (has_new_edges) {
GrB_eWiseAdd(M_graph, NULL, NULL, GrB_LOR, M_graph, DeltaM, NULL);
}

if (CombinedGraph != NULL) {
GrB_free(&CombinedGraph);
}

GrB_Matrix_dup(&CombinedGraph, M_graph);

transitive_closure_inplace(CombinedGraph);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Если я правильн понимаю, что здесь происходит, то можно иначе пересчитывать транзитивыное замыкание. Пусть TC -- результат замыкания с предыдущей итерации, D -- дельта на этой итерации. Тогда можно посчиать transitive_closure_inplace(TC + D). Должно чуть меньше итераций требовать. Но надо проверять, что будет быстрее.


for (int64_t nt = 0; nt < rsm->nonterminal_count; ++nt) {
GrB_Matrix_clear(temp_output);
GrB_Index s = rsm->start_states[nt];

for (GrB_Index i = 0; i < g_dim; ++i) {
row_indices[i] = s * g_dim + i;
}

GrB_Index f_nvals = max_finals;
GrB_Vector_extractTuples_BOOL(f_indices, f_values, &f_nvals, rsm->final_states[nt]);
for (GrB_Index k = 0; k < f_nvals; ++k) {
if (f_values[k]) {
GrB_Index f = f_indices[k];
for (GrB_Index j = 0; j < g_dim; ++j) {
col_indices[j] = f * g_dim + j;
}
GrB_Matrix_extract(temp_output, NULL, GrB_LOR, CombinedGraph,
row_indices, g_dim, col_indices, g_dim, NULL);
}
}

// Calculate delta: we leave only those paths that were not already in outputs[nt]
GrB_Matrix_clear(delta_outputs[nt]);
GrB_assign(delta_outputs[nt], outputs[nt], NULL, temp_output,
GrB_ALL, g_dim, GrB_ALL, g_dim, GrB_DESC_RC);

GrB_Index new_vals;
GrB_Matrix_nvals(&new_vals, delta_outputs[nt]);

if (new_vals > 0) {
changed = true;
// Saving the found paths to the main array
GrB_eWiseAdd(outputs[nt], NULL, NULL, GrB_LOR, outputs[nt], delta_outputs[nt], NULL);
}
}
is_first_iteration = false;
}

free(row_indices); free(col_indices);
free(f_indices); free(f_values);

for (int64_t nt = 0; nt < rsm->nonterminal_count; ++nt) {
GrB_free(&delta_outputs[nt]);
}
free(delta_outputs);

GrB_free(&temp_output);
if (BaseGraph != NULL) GrB_free(&BaseGraph);
if (M_graph != NULL) GrB_free(&M_graph);
if (CombinedGraph != NULL) GrB_free(&CombinedGraph);
if (DeltaM != NULL) GrB_free(&DeltaM);

return GrB_SUCCESS;
}
Loading