Skip to content

Fix some bugs#696

Open
timea-solid wants to merge 6 commits intomainfrom
profileEditA11y
Open

Fix some bugs#696
timea-solid wants to merge 6 commits intomainfrom
profileEditA11y

Conversation

@timea-solid
Copy link
Member

@timea-solid timea-solid commented Feb 19, 2026

  • fixed label bug in select inputs (ui:Classifier)
  • harden code around ACL check
  • select fields changed from readOnly which does not exist to disable

@timea-solid timea-solid changed the title fixed label bug in select inputs Fix some bugs Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes two independent issues: (1) a label display bug in the Classifier select input (the field was missing a label), fixed by wrapping the select element in a container div that also renders a label alongside it — mirroring the existing Choice field pattern; and (2) a layout bug in tabWidget where flex: 2 (a flex-child property) was replaced by display: grid on the inner body main element.

Changes:

  • Refactor the Classifier field in forms.js to wrap the select in a labelled container (outerBox/selectBox), with an attempt to set the select as read-only when the document is not editable
  • Change bodyMainStyle in tabs.ts from flex: 2 to display: grid to fix layout in the tab body content area
  • Update the snapshot in tabs.test.ts.snap to reflect the new style string

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/widgets/forms.js Adds label container and read-only ACL hardening for Classifier field
src/tabs.ts Replaces flex: 2 with display: grid on the tab body main element
test/unit/__snapshots__/tabs.test.ts.snap Updates snapshot to reflect the new display: grid style

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

timea-solid and others added 2 commits March 9, 2026 09:33
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants