Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens type index loading/derivation by validating that URIs are absolute http(s) URLs before using them, and by skipping malformed community entries instead of throwing.
Changes:
- Add
isAbsoluteHttpUri()helper and apply it to community nodes before loading their type indexes. - Add try/catch around per-community
loadTypeIndexesForso a single failing community doesn’t break the whole operation. - Tighten
docDirUri()/ type index suggestion logic to only accept absolute http(s) URIs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
168
to
170
| const dirUri = docDirUri(preferencesFile) | ||
| if (!dirUri) throw new Error(`suggestPrivateTypeIndex: Cannot derive directory for ${preferencesFile.uri}`) | ||
| if (!dirUri || !isAbsoluteHttpUri(dirUri)) throw new Error(`suggestPrivateTypeIndex: Cannot derive directory for ${preferencesFile.uri}`) | ||
| return sym(dirUri + 'privateTypeIndex.ttl') |
There was a problem hiding this comment.
Same redundancy as above: docDirUri() already filters to absolute http(s) URIs, so re-checking isAbsoluteHttpUri(dirUri) here duplicates the validation logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.