Fixing issue where incorrect workspace was being set as None#71
Merged
Fixing issue where incorrect workspace was being set as None#71
Conversation
dacoburn
added
the
product changelog
|
🚀 Preview package published! Install with: pip install --index-url https://test.pypi.org/simple/ --extra-index-url https://pypi.org/simple socketdev==3.0.32.dev1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the
workspaceparameter inFullScanParamswasNone, it was being sent to the Socket API as part of the request URL parameters, causing namespace resolution to fail during full scans and breaking package identification.Root Cause
The
workspacefield inFullScanParamsis optional and defaults toNone. When creating a full scan request, the params were converted to a dictionary and URL-encoded without filtering outNonevalues. This resulted inworkspace=Nonebeing sent in the query string, which the API interpreted as a literal string "None" rather than the absence of a workspace, breaking namespace construction for packages (e.g., treating "@org/package" as "None/@org/package").Fix
Added validation logic in the
create()method (lines 812-814 in fullscans/init.py) to detect whenworkspaceisNoneand remove it from the params dictionary before URL encoding. This follows the same pattern already implemented for thepull_requestparameter, ensuring only valid workspace values are included in API requests.Public Changelog
Nonebeing included as the Workspace name incorrectly for Full Scans