Open
Conversation
Signed-off-by: lelia <lelia@socket.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
--workspacesupport tosocket scan createso scans can be associated with the correct Socket workspace (API workspace query param onCreateOrgFullScan). Also allows persisting a default workspace viasocket scan setup.💡 Note: This PR was previously filed as #1095, but due to targeting
maininstead ofv1.x, it was easier to simply re-create as a fresh PR.Changes
socket scan create --workspace <string>(optional)socket scan setupcan persistdefaults.scan.create.workspacein.socket/socket.jsonworkspacethroughhandleCreateNewScan→fetchCreateOrgFullScan→ SDKcreateFullScan(..., { workspace })refs: SocketDev/socket-python-cli#164 + SocketDev/socket-sdk-python#68
Note
Medium Risk
Adds a new optional CLI/config parameter that is forwarded into the scan-creation API call; risk is mainly around incorrect workspace association or API compatibility when the param is present/absent.
Overview
socket scan createnow accepts--workspace(and can default it from.socket/socket.json), and forwards it throughhandleCreateNewScanintofetchCreateOrgFullScan, which conditionally includesworkspacein theCreateOrgFullScanAPI request.socket scan setupis extended to prompt for and persistdefaults.scan.create.workspace(defaulting to the git remote owner when available), and thescan create --helpsnapshot test is updated to include the new flag.Written by Cursor Bugbot for commit 5c333ad. This will update automatically on new commits. Configure here.