Add ability to prefix e2e tests from CLI#580
Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
Draft
Conversation
svij-sc
reviewed
Apr 7, 2026
Collaborator
svij-sc
left a comment
There was a problem hiding this comment.
A slight design choice I made here when implementing this:
A fixed prefix keeps jobs sorted/grouped --> filterable by identity, while a configurable suffix cleanly captures the variable part (environment, version, run) without disrupting any of that. (Similar to how naming files / tables / etc - prefixes are static and suffixes change)
Thus, Id pref if we instead had something like "override_suffix" or something.
What is this for btw? We just want to differentiate jobs that are run by a single person i.e. adding ${whoami} as part of the name?
Collaborator
|
Suggested alternative: Btw, Since we have support for tests:
cora_nalp_test:
name_suffix: "_on_${now:}_${oc.env:BRANCH_NAME}"
task_config_uri: "gigl/src/mocking/configs/e2e_node_anchor_based_link_prediction_template_gbml_config.yaml"
resource_config_uri: "${oc.env:GIGL_TEST_DEFAULT_RESOURCE_CONFIG,deployment/configs/e2e_cicd_resource_config.yaml}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Do this so we can more easily differentiate between different CI/CD runs :)
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO