Skip to content

Add ability to prefix e2e tests from CLI#580

Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
kmonte/add-e2e-test-prefix
Draft

Add ability to prefix e2e tests from CLI#580
kmontemayor2-sc wants to merge 1 commit intomainfrom
kmonte/add-e2e-test-prefix

Conversation

@kmontemayor2-sc
Copy link
Copy Markdown
Collaborator

@kmontemayor2-sc kmontemayor2-sc commented Apr 7, 2026

Scope of work done

Do this so we can more easily differentiate between different CI/CD runs :)

Where is the documentation for this feature?: N/A

Did you add automated tests or write a test plan?

Updated Changelog.md? NO

Ready for code review?: NO

Copy link
Copy Markdown
Collaborator

@svij-sc svij-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A slight design choice I made here when implementing this:
A fixed prefix keeps jobs sorted/grouped --> filterable by identity, while a configurable suffix cleanly captures the variable part (environment, version, run) without disrupting any of that. (Similar to how naming files / tables / etc - prefixes are static and suffixes change)

Thus, Id pref if we instead had something like "override_suffix" or something.

What is this for btw? We just want to differentiate jobs that are run by a single person i.e. adding ${whoami} as part of the name?

@svij-sc
Copy link
Copy Markdown
Collaborator

svij-sc commented Apr 7, 2026

Suggested alternative: Btw, Since we have support for name_suffix already, we can try adding something like following to our e2e_test.yaml

tests:
  cora_nalp_test:
    name_suffix: "_on_${now:}_${oc.env:BRANCH_NAME}"
    task_config_uri: "gigl/src/mocking/configs/e2e_node_anchor_based_link_prediction_template_gbml_config.yaml"
    resource_config_uri: "${oc.env:GIGL_TEST_DEFAULT_RESOURCE_CONFIG,deployment/configs/e2e_cicd_resource_config.yaml}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants