Skip to content

fix: guard against undefined error in yargs fail callback #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monitoring-smartthings wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: guard against undefined error in yargs fail callback #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7acee51
fix: guard against undefined error in yargs fail callback
monitoring-smartthings May 13, 2026
5c9021f
chore: add changeset for fail callback fix
monitoring-smartthings May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-undefined-error-in-fail-callback.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@smartthings/cli": patch
---

Fix TypeError crash when running `smartthings` or `smartthings -h` without a subcommand. Yargs passes `undefined` as the error argument to the `.fail()` callback for validation failures; the `in` operator threw when the operand was `undefined`.
2 changes: 1 addition & 1 deletion src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const buildInstance = (commands: CommandModule<object, any>[]): Argv => {
/* eslint-enable @typescript-eslint/naming-convention */
.completion('generate-completions-script', 'output completion script setup')
.fail((message, error, yargs) => {
if ('isAxiosError' in error && error.isAxiosError) {
if (error && 'isAxiosError' in error && error.isAxiosError) {
// We don't print axiosError.message here because it just duplicates the things
// we're displaying but unformatted.
const axiosError = error as AxiosError
Expand Down