Skip to content

WWSTCERT-10572 Decora Smart Wi-Fi (2ndGen) Fan Speed Controller#2833

Merged
cbaumler merged 3 commits intomainfrom
new_device/WWSTCERT-10572
Mar 24, 2026
Merged

WWSTCERT-10572 Decora Smart Wi-Fi (2ndGen) Fan Speed Controller#2833
cbaumler merged 3 commits intomainfrom
new_device/WWSTCERT-10572

Conversation

@greens
Copy link
Copy Markdown
Contributor

@greens greens commented Mar 9, 2026

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026 •
edited
Loading

Channel deleted.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026 •
edited
Loading

Test Results

   72 files    492 suites   0s ⏱️
2 689 tests 2 689 ✅ 0 💤 0 ❌
4 550 runs  4 550 ✅ 0 💤 0 ❌

Results for commit 36eaac8.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026 •
edited
Loading

File Coverage
All files 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/attribute_handlers.lua 81% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_handlers/capability_handlers.lua 88% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/utils.lua 85% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/legacy_device_configuration.lua 86% ❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/embedded_cluster_utils.lua 95% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/thermostat_utils/device_configuration.lua 91% ✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/matter-thermostat/src/init.lua 98% ✅

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against 36eaac8

hcarter-775
hcarter-775 reviewed Mar 9, 2026
View reviewed changes
drivers/SmartThings/matter-switch/fingerprints.yml Outdated
productId: 0x1010
deviceProfileName: switch-level
- id: "4251/4101"
deviceLabel: Decora Smart Wi-Fi (2ndGen) Fan Speed Controller
Copy link
Copy Markdown
Contributor

@hcarter-775 hcarter-775 Mar 9, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure this should be in matter switch. Have they looked into a better matching profile in matter thermostat?

To clarify, the partner should only use Matter Switch at present if the device also supports turning a light on and off.

Copy link
Copy Markdown
Contributor

@hcarter-775 hcarter-775 Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the partner is looking to include on/off support, perhaps they should try this driver and see if that works for them. cc: @nickolas-deboom

@cbaumler
Copy link
Copy Markdown
Contributor

cbaumler commented Mar 20, 2026

@hcarter-775 @nickolas-deboom per your recommendation and stakeholder approval, I've moved this fingerprint to matter-thermostat. Please give this another review.

hcarter-775
hcarter-775 reviewed Mar 24, 2026
View reviewed changes
drivers/SmartThings/matter-thermostat/fingerprints.yml Outdated
deviceLabel: Decora Smart Wi-Fi (2ndGen) Fan Speed Controller
vendorId: 0x109B
productId: 0x1005
deviceProfileName: fan-modular
Copy link
Copy Markdown
Contributor

@hcarter-775 hcarter-775 Mar 24, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the tested and expected capabilities, this should be changed to fan-generic, since fan-modular is not a profile today in Matter Thermostat.

Copy link
Copy Markdown
Contributor

@cbaumler cbaumler Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made this change in 36eaac8.

@cbaumler cbaumler merged commit 0e8b55e into main Mar 24, 2026
11 checks passed
@cbaumler cbaumler deleted the new_device/WWSTCERT-10572 branch March 24, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbaumler cbaumler cbaumler left review comments

@hcarter-775 hcarter-775 hcarter-775 approved these changes

@nickolas-deboom nickolas-deboom Awaiting requested review from nickolas-deboom

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@greens @cbaumler @hcarter-775