WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch by InovelliUSA · Pull Request #2654 · SmartThingsCommunity/SmartThingsEdgeDrivers

InovelliUSA · 2025-12-13T02:18:09Z

Check all that apply

Type of Change

WWST Certification Request
- If this is your first time contributing code:
  - I have reviewed the README.md file
  - I have reviewed the CODE_OF_CONDUCT.md file
  - I have signed the CLA
- I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
Bug fix
New feature
Refactor

Checklist

I have performed a self-review of my code
I have commented my code in hard-to-understand areas
I have verified my changes by testing with a device or have communicated a plan for testing
I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Adding the VZW31-SN dimmer switch. This device is very similar to the VZW32-SN so code addition is minimal.

Summary of Completed Tests

Tested on live device and tested with beta user. Need to run through the test suite still.

github-actions · 2025-12-13T02:18:31Z

Duplicate profile check: Passed - no duplicate profiles detected.

github-actions · 2025-12-13T02:19:19Z

Invitation URL:
https://bestow-regional.api.smartthings.com/invite/adMKyypPJKl9

github-actions · 2025-12-13T02:22:23Z

Test Results

72 files 497 suites 0s ⏱️
2 705 tests 2 705 ✅ 0 💤 0 ❌
4 589 runs 4 589 ✅ 0 💤 0 ❌

Results for commit cfeb252.

♻️ This comment has been updated with latest results.

github-actions · 2025-12-13T02:22:25Z

File	Coverage
All files	`96%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/init.lua	`81%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli/vzw31-sn/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli/init.lua	`77%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/multi-metering-switch/init.lua	`91%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/aeotec-heavy-duty/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/zwave-dual-switch/init.lua	`95%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/init.lua	`69%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli-2-channel-smart-plug/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/fibaro-wall-plug-us/init.lua	`93%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/eaton-5-scene-keypad/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/configurations.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/preferences.lua	`99%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/lazy_load_subdriver.lua	`57%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/inovelli/lzw31-sn/init.lua	`89%`	❌
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/zooz-power-strip/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/qubino-flush-2-relay/init.lua	`97%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/aeotec-smart-switch/init.lua	`98%`	✅
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-switch/src/qubino-switches/qubino-relays/qubino-flush-1d-relay/init.lua	`80%`	❌

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against cfeb252

InovelliUSA · 2025-12-20T23:56:02Z

I got the certification request in and passed the test suite. One thing that was strange is that the default multilevel report handler was not sending the level: 0 event. This was causing the driver to timeout when set to 0%. I verified that my device was sending the correct report:

2025-12-20T23:16:21.173926679Z INFO Z-Wave Switch <ZwaveDevice: b79a7858-b383-4072-aaf9-9b5dc1a5e96b [84] (Inovelli Dimmer Red Series)> received Z-Wave command: {args={current_value="OFF_DISABLE", duration=0, target_value=0, value="OFF_DISABLE"}, cmd_class="SWITCH_MULTILEVEL", cmd_id="REPORT", dst_channels={}, encap="NONE", payload="\x00\x00\x00", src_channel=0, version=4}

To get it to pass the test I had to handle that report myself. I did not test yet if this is a problem on other devices (maybe something got changed on the default multilevel report handling)?

local function onoff_level_report_handler(driver, device, cmd)
local value = cmd.args.target_value and cmd.args.target_value or cmd.args.value
device:emit_event(value == 0 and capabilities.switch.switch.off() or capabilities.switch.switch.on())
device:emit_event(capabilities.switchLevel.level(value))
end

If I need to create some unit tests I can do it next week.

greens

Yes, please include some unit tests.

I'm not seeing anything in the default handler that would result in the message you posted failing. If you could reproduce and then upload hub logs I could check if you share the hub ID. (At https://my.smartthings.com/advanced under "hubs" click "dump hub logs").

InovelliUSA · 2026-01-23T02:10:06Z

Yes, please include some unit tests.

I'm not seeing anything in the default handler that would result in the message you posted failing. If you could reproduce and then upload hub logs I could check if you share the hub ID. (At https://my.smartthings.com/advanced under "hubs" click "dump hub logs").

Sorry I lost track of this and will try to get to it tomorrow.

InovelliUSA · 2026-03-15T03:35:02Z

@greens I got distracted on other projects, but just pushed several tests up for this commit.

cjswedes · 2026-03-30T18:31:04Z

drivers/SmartThings/zwave-switch/src/inovelli/vzw31-sn/init.lua

+local supported_button_values = {
+  ["button1"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"},
+  ["button2"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"},
+  ["button3"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"}
+}


Suggested change

local supported_button_values = {

["button1"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"},

["button2"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"},

["button3"] = {"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"}

}

local supported_button_values =

{"pushed","held","down_hold","pushed_2x","pushed_3x","pushed_4x","pushed_5x"}

Since they are all the same, you dont need to define them 3 times.

Thanks, I made the adjustment. There is a Jenkins driver test failure though, but I don't think that is from my change. Maybe it is ?

I'm looking into this. Currently passing against the latest release artifact here, so it should be good.

Inovelli - adding vzw31 red series dimmer switch

ac36f84

needed to add multilevel report handler to pass test suite

e6f6b78

greens reviewed Jan 12, 2026

View reviewed changes

greens changed the title ~~Inovelli - adding vzw31 red series dimmer switch~~ WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch Jan 12, 2026

InovelliUSA added 2 commits March 14, 2026 21:01

adding tests for vzw31

44508cd

Merge remote-tracking branch 'upstream/main' into inovelli-vzw31-sn

f6a24ec

cbaumler requested review from ctowns and hcarter-775 March 18, 2026 21:33

cbaumler requested review from aleclorimer and cjswedes and removed request for ctowns and hcarter-775 March 27, 2026 18:41

cjswedes approved these changes Mar 30, 2026

View reviewed changes

removing extra code for button value init

cfeb252

aleclorimer approved these changes Mar 31, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch#2654

WWSTCERT-9786 Inovelli - adding vzw31 red series dimmer switch#2654
InovelliUSA wants to merge 5 commits intoSmartThingsCommunity:mainfrom
InovelliUSA:inovelli-vzw31-sn

InovelliUSA commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 13, 2025 •

edited

Loading

Uh oh!

InovelliUSA commented Dec 20, 2025

Uh oh!

greens left a comment •

edited

Loading

Uh oh!

InovelliUSA commented Jan 23, 2026

Uh oh!

InovelliUSA commented Mar 15, 2026

Uh oh!

cjswedes Mar 30, 2026

Uh oh!

InovelliUSA Mar 31, 2026

Uh oh!

aleclorimer Mar 31, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

InovelliUSA commented Dec 13, 2025

Type of Change

Checklist

Description of Change

Summary of Completed Tests

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025

Uh oh!

github-actions bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

github-actions bot commented Dec 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

InovelliUSA commented Dec 20, 2025

Uh oh!

greens left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

InovelliUSA commented Jan 23, 2026

Uh oh!

InovelliUSA commented Mar 15, 2026

Uh oh!

cjswedes Mar 30, 2026

Choose a reason for hiding this comment

Uh oh!

InovelliUSA Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

aleclorimer Mar 31, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 13, 2025 •

edited

Loading

github-actions bot commented Dec 13, 2025 •

edited

Loading

greens left a comment •

edited

Loading