fix: use transaction id in reset response#1767
Merged
loucass003 merged 2 commits intoSlimeVR:mainfrom Apr 16, 2026
Merged
Conversation
notpeelz
requested review from
ButterscotchV,
Eirenliel and
Erimelowo
as code owners
ButterscotchV
requested changes
Mar 3, 2026
Member
ButterscotchV
left a comment
ButterscotchV
left a comment
There was a problem hiding this comment.
Looks fine besides this overload weirdness, seems to be a continuation of #1527.
ButterscotchV
approved these changes
Mar 5, 2026
ImSapphire
approved these changes
Mar 19, 2026
notpeelz
force-pushed
the
fix-reset-resp-tx-id
branch
from
93d21c6 to
8a35de4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the reset response to use the transaction id of the request, for use in solarxr-cli.
The use case is for implementing a blocking mode (
--waitoption) insolarxr-cli reset <type>.This is especially useful for chaining commands, eg:
solarxr-cli branch: https://github.com/notpeelz/solarxr-cli/tree/feat-reset-transaction