Merged
Conversation
sctanf
requested review from
ButterscotchV,
Eirenliel,
Erimelowo and
loucass003
as code owners
github-actions
Bot
added
Area: Hardware Protocol
ButterscotchV
approved these changes
Feb 18, 2026
loucass003
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Server will hide battery icon if 0% is sent, but in some cases this is a valid state. Using -1 or 255 to represent 0% would hopefully not break anything else but should properly show the icon now.
I'm not sure about certain behavior when batteryLevel in server gets cast to uint8 to send to gui, e.g. it may allow 255 and not -1.