Skip to content

[Security] Fix command injection risk in cloudflared installer#7473

Draft
gonzaloriestra wants to merge 1 commit intomainfrom
fix-cloudflared-command-injection-2-17491907231653004163
Draft

[Security] Fix command injection risk in cloudflared installer#7473
gonzaloriestra wants to merge 1 commit intomainfrom
fix-cloudflared-command-injection-2-17491907231653004163

Conversation

@gonzaloriestra
Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes a potential command injection vulnerability in the Cloudflare installer. The previous implementation used execSync with a template literal containing a variable derived from an environment variable (SHOPIFY_CLI_CLOUDFLARED_PATH), which could be exploited to execute arbitrary commands if the environment was compromised.

WHAT is this pull request doing?

  • Replaces direct child_process.execSync and child_process.execFileSync calls with secure wrappers exec and captureOutputWithExitCode from @shopify/cli-kit/node/system.
  • Switched to argument-list-based command execution for tar to prevent shell injection.
  • Removed direct child_process imports to ensure all command executions go through @shopify/cli-kit which implements checkCommandSafety.
  • Updated unit tests in install-cloudflared.test.ts to match the new asynchronous implementation and use the correct mocks.

How to test your changes?

Run the unit tests for the affected package:

pnpm --filter @shopify/plugin-cloudflare vitest run

Duplicate check

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 17491907231653004163 started by @gonzaloriestra

Replaced direct child_process calls with secure wrappers from @shopify/cli-kit.
Switched to argument-list-based command execution to prevent shell injection.
Updated unit tests to match new implementation.
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the Area: @shopify/cli @shopify/cli package issues label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/cli @shopify/cli package issues security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant