Redirect to app redirect landing page in admin#7031
Conversation
Coverage report
Test suite run success3797 tests passing in 1467 suites. Report generated by 🧪jest coverage report action from 5d9d9d4 |
8792dc6 to
5d9d9d4
Compare
|
One implementation note: this PR intentionally does not change globally.\n\nThe bug here is specifically about the preview-entry URL for , so the change is scoped to store-aware preview URL building and local-store preview wiring. That fixes the user-facing flow without changing the broader local admin host convention repo-wide.\n\nThere is still a separate local-dev consistency question around vs for generic admin host helpers. If we want to clean that up, I think it should be a follow-up that audits current callers and decides whether they want a generic admin host or a store-scoped unified admin URL. |
|
Follow-up on the note above — reposting with formatting fixed: This PR intentionally does not change The bug here is specifically about the preview-entry URL for There is still a separate local-dev consistency question around |

What
Route the CLI preview URL through the admin-web preflight entrypoint instead of linking directly into the app redirect flow.
Use the same preview entry URL shape for local stores, with
admin.shop.devas the unified admin host.Why
Pressing
pfromshopify app devshould reopen Dev Console through the UI layer that owns that state.Sending the browser directly to Core's redirect flow gets the app installed or redirected, but it does not reliably restore Dev Console for all app shapes. Moving the entrypoint to admin-web keeps the Dev Console concern in admin-web instead of threading it through OAuth and callback URLs.
How
buildAppURLForWebto generate/store/<store>/extensions-dev/preview?client_id=...admin.shopify.comadmin.shop.devsetup-dev-processesapp.urlTesting
Manual verification:
apps-platformrig in local developmentAdditional checks:
shopify app devagainst a production-like store and presspSHOPIFY_SERVICE_ENV=local shopify app devagainst a local store and confirm the preview URL useshttps://admin.shop.dev/store/<store>/extensions-dev/preview?...