Smaller bundle by gonzaloriestra · Pull Request #7013 · Shopify/cli

gonzaloriestra · 2026-03-13T16:20:29Z

WHY are these changes introduced?

The bundle is too heavy

WHAT is this pull request doing?

Reduces CLI bundle size by ~89% (62 MB → 7 MB)

Disable source maps (~35.7 MB saved, stack traces still readable)
Enable esbuild minifyWhitespace and minifyIdentifiers (~18.8 MB saved)
Replace brotli JS package with native zlib.brotliCompressSync (~5.9 MB saved)
Externalize 30+ large runtime dependencies (prettier, ts-morph, typescript, polaris, react-dom, vscode language services, @opentelemetry, ink/react, @oclif/core, etc.) (~55 MB saved)
Exclude 11 .test.ts files that were accidentally bundled as entry points (~348 KB saved)

How to test your changes?

npm i -g @shopify/cli@0.0.0-snapshot-20260313171105
shopify app dev
shopify theme dev

Measuring impact

How do we know this change was effective? Please choose one:

n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
Existing analytics will cater for this addition
PR includes analytics changes to measure impact

Checklist

I've considered possible cross-platform impacts (Mac, Linux, Windows)
I've considered possible documentation changes

… — saves ~5,904 KB\n\nResult: {"status":"keep","bundle_kb":125332,"js_kb":46412,"maps_kb":74152,"assets_kb":4768}

…784, maps: -2,328)\n\nResult: {"status":"keep","bundle_kb":111220,"js_kb":34628,"maps_kb":71824,"assets_kb":4768}

…ings)\n\nResult: {"status":"keep","bundle_kb":99508,"js_kb":30844,"maps_kb":63896,"assets_kb":4768}

…. Already lazy-loaded via dynamic import.\n\nResult: {"status":"keep","bundle_kb":76368,"js_kb":22848,"maps_kb":48752,"assets_kb":4768}

…ble at runtime as project dep.\n\nResult: {"status":"keep","bundle_kb":57192,"js_kb":16500,"maps_kb":35924,"assets_kb":4768}

…dable (identifiers not minified).\n\nResult: {"status":"keep","bundle_kb":21440,"js_kb":16500,"maps_kb":172,"assets_kb":4768}

…36)\n\nResult: {"status":"keep","bundle_kb":16776,"js_kb":11836,"maps_kb":172,"assets_kb":4768}

…,132 KB\n\nResult: {"status":"keep","bundle_kb":15644,"js_kb":10704,"maps_kb":172,"assets_kb":4768}

…s 524 KB\n\nResult: {"status":"keep","bundle_kb":15120,"js_kb":10180,"maps_kb":172,"assets_kb":4768}

… KB\n\nResult: {"status":"keep","bundle_kb":14128,"js_kb":9188,"maps_kb":172,"assets_kb":4768}

…conciler@0.29.2) — saves 424 KB\n\nResult: {"status":"keep","bundle_kb":13704,"js_kb":8764,"maps_kb":172,"assets_kb":4768}

…ed impact)\n\nResult: {"status":"keep","bundle_kb":13592,"js_kb":8652,"maps_kb":172,"assets_kb":4768}

…Result: {"status":"keep","bundle_kb":13176,"js_kb":8236,"maps_kb":172,"assets_kb":4768}

…-parser, @vscode/web-custom-data — saves 1,136 KB\n\nResult: {"status":"keep","bundle_kb":12040,"js_kb":7100,"maps_kb":172,"assets_kb":4768}

…mver, yaml, js-yaml, execa — saves 1,100 KB\n\nResult: {"status":"keep","bundle_kb":10940,"js_kb":6000,"maps_kb":172,"assets_kb":4768}

…eing bundled) — saves 348 KB\n\nResult: {"status":"keep","bundle_kb":10592,"js_kb":5652,"maps_kb":172,"assets_kb":4768}

… 20+ more runtime deps — saves 1,868 KB\n\nResult: {"status":"keep","bundle_kb":8724,"js_kb":3784,"maps_kb":172,"assets_kb":4768}

gonzaloriestra · 2026-03-13T16:26:22Z

/snapit

github-actions · 2026-03-13T16:27:31Z

Coverage report

St.^❔	Category	Percentage	Covered / Total
🟡	Statements	77.24%	14565/18857
🟡	Branches	70.88%	7227/10196
🟡	Functions	76.21%	3701/4856
🟡	Lines	78.73%	13767/17487

Test suite run success

3806 tests passing in 1462 suites.

Report generated by 🧪jest coverage report action from 696e5f7

gonzaloriestra · 2026-03-13T17:10:16Z

/snapit

github-actions · 2026-03-13T17:12:38Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260313171105

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

isaacroldan · 2026-03-16T14:54:59Z

packages/cli/bin/bundle.js

+  'is-executable',
+  'macaddress',
+  'network-interfaces',
+  'diff',


I mean, putting all dependencies as external defeats the purpose of a bundle 😅

isaacroldan · 2026-03-16T14:55:35Z

packages/cli/bin/bundle.js

@@ -53,14 +175,14 @@ esBuild({
  },
  inject: ['../../bin/bundling/cjs-shims.js'],
  external,
-  sourcemap: true,
+  sourcemap: false,


We need sourcemaps for Observe. They are not included in the final bundle though (they shouldn't at least)

gonzaloriestra · 2026-03-17T16:05:35Z

/snapit

github-actions · 2026-03-17T16:08:44Z

🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260317160706

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

isaacroldan · 2026-03-17T16:48:22Z

packages/cli/bin/bundle.js

 esBuild({
  bundle: true,
-  entryPoints: ['./src/**/*.ts'],
+  entryPoints: (await glob('./src/**/*.ts')).filter(f => !f.includes('.test.')),


entry point can be simplified to ['./src/index.ts']

isaacroldan · 2026-03-17T16:48:31Z

packages/cli/bin/bundle.js

  inject: ['../../bin/bundling/cjs-shims.js'],
  external,
-  sourcemap: true,
+  sourcemap: 'external',


what does this do?

isaacroldan · 2026-03-17T16:49:42Z

packages/cli/bin/bundle.js

+  // prettier is ~4MB and only used for formatting generated types.
+  // Lazily loaded via dynamic import, safe to externalize.
+  'prettier',
+  // ts-morph + typescript are ~19MB. Used by Hydrogen for JS/TS transpilation.
+  // Already lazily loaded via dynamic import, safe to externalize.
+  'ts-morph',
+  // typescript compiler (~9MB) is pulled in by ts-morph and json-schema-to-typescript.
+  // Available at runtime as a project dependency.
+  'typescript',


making this external means that they are need to be installed by npm, so they don't count for the "bundle size", but this is actually slower because npm needs to find them, resolve them, and download them.

We should only mark as external dependencies that are incompatible with bundling (like esbuild)

gonzaloriestra added 20 commits March 13, 2026 15:36

autoresearch: setup bundle size optimization

66b3c93

fix checks script - remove broken lint

74a2dbe

Replace brotli JS package with native Node.js zlib.brotliCompressSync…

80bec98

… — saves ~5,904 KB\n\nResult: {"status":"keep","bundle_kb":125332,"js_kb":46412,"maps_kb":74152,"assets_kb":4768}

Enable minifyWhitespace in esbuild bundle — saves 14,112 KB (JS: -11,…

7d2e82b

…784, maps: -2,328)\n\nResult: {"status":"keep","bundle_kb":111220,"js_kb":34628,"maps_kb":71824,"assets_kb":4768}

Externalize prettier from bundle (~4MB input, ~11.7MB output+maps sav…

2fc10d7

…ings)\n\nResult: {"status":"keep","bundle_kb":99508,"js_kb":30844,"maps_kb":63896,"assets_kb":4768}

Externalize ts-morph (+ typescript dep) from bundle — saves 23,140 KB…

eabc031

…. Already lazy-loaded via dynamic import.\n\nResult: {"status":"keep","bundle_kb":76368,"js_kb":22848,"maps_kb":48752,"assets_kb":4768}

Externalize typescript compiler from bundle — saves 19,176 KB. Availa…

303ce3b

…ble at runtime as project dep.\n\nResult: {"status":"keep","bundle_kb":57192,"js_kb":16500,"maps_kb":35924,"assets_kb":4768}

Disable esbuild source maps — saves 35,752 KB. Stack traces still rea…

cdf329f

…dable (identifiers not minified).\n\nResult: {"status":"keep","bundle_kb":21440,"js_kb":16500,"maps_kb":172,"assets_kb":4768}

Enable minifyIdentifiers in esbuild — saves 4,664 KB (JS: 16,500→11,8…

8f75609

…36)\n\nResult: {"status":"keep","bundle_kb":16776,"js_kb":11836,"maps_kb":172,"assets_kb":4768}

Externalize @shopify/polaris, polaris-icons, polaris-tokens — saves 1…

d31c979

…,132 KB\n\nResult: {"status":"keep","bundle_kb":15644,"js_kb":10704,"maps_kb":172,"assets_kb":4768}

Externalize react-dom (only used for GraphiQL SSR, not by ink) — save…

6e2d804

…s 524 KB\n\nResult: {"status":"keep","bundle_kb":15120,"js_kb":10180,"maps_kb":172,"assets_kb":4768}

Externalize vscode language service packages (~2MB input) — saves 992…

0c6f5ca

… KB\n\nResult: {"status":"keep","bundle_kb":14128,"js_kb":9188,"maps_kb":172,"assets_kb":4768}

Externalize @oclif/table (avoids bundling ink@5 + react@18 + react-re…

715bdbd

…conciler@0.29.2) — saves 424 KB\n\nResult: {"status":"keep","bundle_kb":13704,"js_kb":8764,"maps_kb":172,"assets_kb":4768}

Externalize lodash — saves 112 KB (partial tree-shaking already reduc…

d9bb563

…ed impact)\n\nResult: {"status":"keep","bundle_kb":13592,"js_kb":8652,"maps_kb":172,"assets_kb":4768}

Externalize @opentelemetry packages (~1.3MB input) — saves 416 KB\n\n…

982d6c4

…Result: {"status":"keep","bundle_kb":13176,"js_kb":8236,"maps_kb":172,"assets_kb":4768}

Externalize theme-check/language-server packages, ohm-js, liquid-html…

95b5321

…-parser, @vscode/web-custom-data — saves 1,136 KB\n\nResult: {"status":"keep","bundle_kb":12040,"js_kb":7100,"maps_kb":172,"assets_kb":4768}

Externalize ink, react, react-reconciler, ajv, archiver, liquidjs, se…

a32d91d

…mver, yaml, js-yaml, execa — saves 1,100 KB\n\nResult: {"status":"keep","bundle_kb":10940,"js_kb":6000,"maps_kb":172,"assets_kb":4768}

Exclude test files from bundle entry points (11 .test.ts files were b…

1eaab72

…eing bundled) — saves 348 KB\n\nResult: {"status":"keep","bundle_kb":10592,"js_kb":5652,"maps_kb":172,"assets_kb":4768}

Externalize @oclif/core, graphql, zod, jose, node-fetch, got, ws, and…

7099347

… 20+ more runtime deps — saves 1,868 KB\n\nResult: {"status":"keep","bundle_kb":8724,"js_kb":3784,"maps_kb":172,"assets_kb":4768}

Last step

6f58b49

Fix bundle issue

766c9b6

gonzaloriestra added 2 commits March 13, 2026 18:24

Fix lint and knip

c2d577a

Remove temp files

2f363e9

isaacroldan reviewed Mar 16, 2026

View reviewed changes

gonzaloriestra force-pushed the smaller-bundle branch from d564ba3 to 9893f54 Compare March 17, 2026 13:28

Only externalize some deps and enable sourcemap

696e5f7

gonzaloriestra force-pushed the smaller-bundle branch from 9893f54 to 696e5f7 Compare March 17, 2026 15:10

isaacroldan reviewed Mar 17, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Smaller bundle#7013

Smaller bundle#7013
gonzaloriestra wants to merge 24 commits intomainfrom
smaller-bundle

gonzaloriestra commented Mar 13, 2026 •

edited

Loading

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026 •

edited

Loading

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

isaacroldan Mar 16, 2026

Uh oh!

isaacroldan Mar 16, 2026

Uh oh!

gonzaloriestra commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

isaacroldan Mar 17, 2026

Uh oh!

isaacroldan Mar 17, 2026

Uh oh!

isaacroldan Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gonzaloriestra commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

WHY are these changes introduced?

WHAT is this pull request doing?

How to test your changes?

Measuring impact

Checklist

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report

Test suite run success

Uh oh!

gonzaloriestra commented Mar 13, 2026

Uh oh!

github-actions bot commented Mar 13, 2026

Uh oh!

isaacroldan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

isaacroldan Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

gonzaloriestra commented Mar 17, 2026

Uh oh!

github-actions bot commented Mar 17, 2026

Uh oh!

isaacroldan Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

isaacroldan Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

isaacroldan Mar 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gonzaloriestra commented Mar 13, 2026 •

edited

Loading

github-actions bot commented Mar 13, 2026 •

edited

Loading