Skip to content

Evol ros2_control & rviz2#25

Merged
charlesmadjeri merged 7 commits intodevfrom
cma/evol-ros2-control
Apr 15, 2026
Merged

Evol ros2_control & rviz2#25
charlesmadjeri merged 7 commits intodevfrom
cma/evol-ros2-control

Conversation

@charlesmadjeri
Copy link
Copy Markdown
Contributor

@charlesmadjeri charlesmadjeri commented Feb 14, 2026 •
edited
Loading

Goal: Make the panel speak ros2_control (and RViz-facing joint APIs): config-driven joints, smoother commands, and alignment with updated URDF (shoulder z).

  • Documentation base: archi diagram
  • *Config foundation: env/example and app wiring toward a Configuration page.
  • ros2_control / RViz: ROS constants, joint handling, JointState.handler refactor, panel/viewer/navigation updates (RobotControlPanel, PoseManager, JointControl, etc.).
  • Trajectory smoothing: smoother joint trajectory path in JointState.handler.
  • Joint UX: min/default from config, reset to rest.
  • URDF parity: missing shoulder z in joint definitions.

@charlesmadjeri
evol(ros2control): handle joints for ros2control and rviz
3e04e0c 
Signed-off-by: Charles Madjeri <charles@madjeri.com>
@charlesmadjeri charlesmadjeri self-assigned this Feb 14, 2026
@charlesmadjeri
fix(jointState): add smooth joint trajectory
ece1a55 
Signed-off-by: Charles Madjeri <charles@madjeri.com>
Mael-RABOT
Mael-RABOT previously approved these changes Mar 18, 2026
View reviewed changes
@charlesmadjeri
fix(joints): min value from config and reset to rest value
798eeed 
Signed-off-by: Charles Madjeri <charles@madjeri.com>
@charlesmadjeri
Copy link
Copy Markdown
Contributor Author

charlesmadjeri commented Mar 20, 2026

Still need testing and fix to be worky with real robot trough ros2_control. Worky with rviz

@charlesmadjeri
fix(joints): add missing shoulder z
5ca89d8 
Signed-off-by: Charles Madjeri <charles@madjeri.com>
@charlesmadjeri charlesmadjeri changed the title evol(ros2control): handle joints for ros2control and rviz Evol ros2_control & rviz2 Mar 20, 2026
@charlesmadjeri charlesmadjeri changed the base branch from mra/feat-configuration-ui to dev March 28, 2026 23:56
@charlesmadjeri charlesmadjeri dismissed Mael-RABOT’s stale review March 28, 2026 23:56

The base branch was changed.

Arcod7
Arcod7 previously approved these changes Mar 29, 2026
View reviewed changes
Copy link
Copy Markdown

@Arcod7 Arcod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread src/Pages/RobotControlPanel.tsx
Comment thread src/Pages/RobotControlPanel.tsx
Comment thread src/Pages/RobotControlPanel.tsx
Mael-RABOT
Mael-RABOT requested changes Mar 29, 2026
View reviewed changes
Comment thread src/Services/ros/handlers/JointState.handler.ts
Comment thread src/Services/ros/ros.service.ts
@charlesmadjeri
feat(docs): add base archi for documentation
5085e26 
Signed-off-by: Charles Madjeri <charles@madjeri.com>
Mael-RABOT
Mael-RABOT previously approved these changes Apr 14, 2026
View reviewed changes
@Mael-RABOT
Copy link
Copy Markdown
Contributor

Mael-RABOT commented Apr 14, 2026

image

m-brl
m-brl previously approved these changes Apr 14, 2026
View reviewed changes
Comment thread .nvmrc Outdated
@charlesmadjeri
fix(docs): add base documentation and archi diagram
c4f6ffb 
Signed-off-by: Charles Madjeri <80175305+charlesmadjeri@users.noreply.github.com>
@charlesmadjeri charlesmadjeri dismissed stale reviews from m-brl and Mael-RABOT via c4f6ffb April 14, 2026 13:29
@charlesmadjeri charlesmadjeri force-pushed the cma/evol-ros2-control branch from 83b44a8 to c4f6ffb Compare April 14, 2026 13:29
Arcod7
Arcod7 approved these changes Apr 15, 2026
View reviewed changes
Copy link
Copy Markdown

@Arcod7 Arcod7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesmadjeri charlesmadjeri merged commit f0140d5 into dev Apr 15, 2026
@charlesmadjeri charlesmadjeri deleted the cma/evol-ros2-control branch April 15, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Arcod7 Arcod7 Arcod7 approved these changes

@m-brl m-brl m-brl approved these changes

@Mael-RABOT Mael-RABOT Mael-RABOT left review comments

Assignees

@charlesmadjeri charlesmadjeri

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@charlesmadjeri @Mael-RABOT @Arcod7 @m-brl