Skip to content

마이페이지 레벨 프로그레스바 stop indicator 렌더링 오류 수정 #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
unam98 merged 1 commit into from
May 8, 2026
Merged

마이페이지 레벨 프로그레스바 stop indicator 렌더링 오류 수정 #387

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/src/main/java/com/runnect/runnect/presentation/mypage/MyPageScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,8 @@ private fun LevelProgressSection(
.clip(RoundedCornerShape(5.dp)),
color = M1,
trackColor = G4,
drawStopIndicator = {},
gapSize = 0.dp,
Copy link
Copy Markdown
Collaborator Author

@unam98 unam98 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Nit] gapSize = 0.dp 중복

drawStopIndicator = {}로 indicator 자체를 그리지 않으므로 gapSize(indicator와 progress bar 사이 간격)는 영향이 없습니다. 제거해도 동일하게 동작합니다.

단, 명시적으로 gap 의도를 제거한다는 의미로 남겨두는 것도 나쁘지 않아서 필수 수정은 아닙니다.

Copy link
Copy Markdown
Collaborator Author

@unam98 unam98 May 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

현재 코드 유지

M3 1.4.0 소스(ProgressIndicator.kt) 직접 확인 결과, gapSize와 drawStopIndicator는 서로 독립적으로 동작합니다.

// ProgressIndicator.kt 핵심 로직
val gapSizeFraction = adjustedGapSize / size.width.toDp()
val trackStartFraction =
    currentCoercedProgress + min(currentCoercedProgress, gapSizeFraction)
drawLinearIndicator(trackStartFraction, 1f, trackColor, ...)  // track
drawLinearIndicator(0f, currentCoercedProgress, color, ...)   // progress
drawStopIndicator(this)                                        // stop indicator (별개)

gapSize는 progress bar와 track 사이의 시각적 간격을 제어하며, drawStopIndicator(indicator 점) 렌더링과 무관합니다. gapSize = 0.dp가 없으면 progress가 0%보다 클 때 progress와 track 사이에 기본 간격(LinearIndicatorTrackGapSize)이 생깁니다.

원래 리뷰 코멘트의 전제가 틀렸습니다. 수정하지 않는 것이 맞습니다.

)
Spacer(modifier = Modifier.height(10.dp))
Row(
Expand Down
Loading