Closed
Conversation
…elationalAI/logical-query-protocol into berkay-add-optimization-levels
comnik
reviewed
Mar 10, 2026
Collaborator
There was a problem hiding this comment.
This file seems wrong? The pretty printer should be in sdks/go/src/pretty.go
comnik
reviewed
Mar 10, 2026
Collaborator
There was a problem hiding this comment.
Same here, all the julia code should be in sdks/julia
comnik
requested changes
Mar 10, 2026
Collaborator
comnik
left a comment
comnik
left a comment
There was a problem hiding this comment.
@aydogduberkay I think something went wrong here due to the outdated branch. The SDK files are all over the place now. Could you start from scratch on a fresh branch off of main?
aydogduberkay
changed the title
Collaborator
Author
|
Will do this from scratch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend Configurations with Optimization Level
This PR introduces an optimization level setting to the Configurations, allowing users to select between three modes:
default,conservative, andaggressive. If no level is specified, the system defaults todefault.default: Applies default optimizations.conservative: Applies newer optimizations which we have gained experience with, but still prioritizes stability.aggressive: Enables any optimization available, including newly implemented ones. This may lead to the best performance but may not be stable.