Closed
Conversation
Contributor
Author
|
It doesn't look like anybody upstream in svd2rust wants to merge this CCP stuff, so I am going to close this here and submit a PR for the Attiny417/817/1617/3217 in a few minutes without the CCP things. I looked through the SVD spec to figure out if we can properly support generating code to write to CCP-protected registers, but I can't seem to find a viable solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds support for the Attiny817.
This change depends on a patch that I just submitted to
svd2rust: rust-embedded/svd2rust#784I implemented a more convenient method to modify the configuration change protected registers that show up in these new cores. Unfortunately, you still need to define these registers manually for every single chip like I do in
ccp.rsin this patch. There might be a way to get this information from the ATDF, carry it over into the SVD and then generate that as well usingsvd2rust. However, it's only a handful of registers for every chip, so I didn't look too much into it.This might be applicable to other chips that are already supported in this crate like the ATtiny816 or 1614. Essentially all the new cores have some of these protected registers.