Skip to content

Some updates#39

Merged
dewabisma merged 3 commits into
mainfrom
feat/some-updates
May 26, 2026
Merged

Some updates#39
dewabisma merged 3 commits into
mainfrom
feat/some-updates

Conversation

@dewabisma
Copy link
Copy Markdown
Collaborator

@dewabisma dewabisma commented May 26, 2026

Note

Low Risk
UI and navigation changes with shared routing logic; wormhole redirect is user-visible but localized and uses replace navigation.

Overview
Centralizes extrinsic deep-linking in getExtrinsicDetailPath (wormhole, balances, reversible transfer calls) and wires it through extrinsic/transaction table columns and search preview, so links land on the right detail route instead of always using the generic transaction URL.

Block tables can now sort by extrinsic count: the column enables sorting, BlockSorts gains extrinsics_aggregate.count, and block listing hooks use transformBlockOrderBy instead of useOrderBy so extrinsicsCount:asc|desc maps to the API shape.

Transaction detail redirects wormhole extrinsics to /wormhole/$id with replace: true while data loads. Wormhole output details show skeleton placeholders during load and only render exit outputs / nullifiers sections when loading or data exists (including a fixed nullifier skeleton count while loading).

Also adds a .cursor/skills/code-review skill file (review guidelines only; no runtime behavior).

Reviewed by Cursor Bugbot for commit f0422ba. Bugbot is set up for automated code reviews on this repo. Configure here.

@dewabisma dewabisma merged commit 47dccef into main May 26, 2026
3 checks passed
@dewabisma dewabisma deleted the feat/some-updates branch May 26, 2026 06:36
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit f0422ba. Configure here.

const outputs = extrinsic?.outputs ?? [];
const showExitOutputs = loading || outputs.length > 0;
const showNullifiers = loading || nullifiers.length > 0;
const nullifierCount = loading ? 16 : nullifiers.length;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong nullifier count while loading

Low Severity

While wormhole detail data is loading, the Nullifiers block is shown with copy stating that 16 nullifiers were consumed, and 16 placeholder rows are rendered. After load, extrinsics with zero nullifiers hide the section entirely, so users briefly see incorrect factual text.

Additional Locations (1)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit f0422ba. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant