Some updates#39
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f0422ba. Configure here.
| const outputs = extrinsic?.outputs ?? []; | ||
| const showExitOutputs = loading || outputs.length > 0; | ||
| const showNullifiers = loading || nullifiers.length > 0; | ||
| const nullifierCount = loading ? 16 : nullifiers.length; |
There was a problem hiding this comment.
Wrong nullifier count while loading
Low Severity
While wormhole detail data is loading, the Nullifiers block is shown with copy stating that 16 nullifiers were consumed, and 16 placeholder rows are rendered. After load, extrinsics with zero nullifiers hide the section entirely, so users briefly see incorrect factual text.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit f0422ba. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Note
Low Risk
UI and navigation changes with shared routing logic; wormhole redirect is user-visible but localized and uses replace navigation.
Overview
Centralizes extrinsic deep-linking in
getExtrinsicDetailPath(wormhole, balances, reversible transfer calls) and wires it through extrinsic/transaction table columns and search preview, so links land on the right detail route instead of always using the generic transaction URL.Block tables can now sort by extrinsic count: the column enables sorting,
BlockSortsgainsextrinsics_aggregate.count, and block listing hooks usetransformBlockOrderByinstead ofuseOrderBysoextrinsicsCount:asc|descmaps to the API shape.Transaction detail redirects wormhole extrinsics to
/wormhole/$idwithreplace: truewhile data loads. Wormhole output details show skeleton placeholders during load and only render exit outputs / nullifiers sections when loading or data exists (including a fixed nullifier skeleton count while loading).Also adds a
.cursor/skills/code-reviewskill file (review guidelines only; no runtime behavior).Reviewed by Cursor Bugbot for commit f0422ba. Bugbot is set up for automated code reviews on this repo. Configure here.