7 leaf proofs#569
Open
illuzen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this also needs to update to latest qp-zk-circuits after release
Note
Medium Risk
Changes embedded ZK circuit binaries and proof aggregation capacity unless builds override
QP_NUM_LEAF_PROOFS, which can affect verifier compatibility and proof batching behavior.Overview
Default wormhole ZK aggregation size is reduced from 16 to 7 leaf proofs when
QP_NUM_LEAF_PROOFSis unset. Thepallets/wormhole/build.rsscript still passes that value intogenerate_all_circuit_binaries, so generatedaggregated_*binaries and anything compiled in viainclude_bytes!will match the smaller tree.Comments document the tradeoff: 7 leaves target
degree_bits=15(~1.5 GB peak on mobile); 8+ pushesdegree_bits=16(~2.5 GB), which the team treats as viable mainly on 6GB+ devices.Reviewed by Cursor Bugbot for commit fc0c9f5. Bugbot is set up for automated code reviews on this repo. Configure here.