feat: update LineService.create to use JSON endpoint with version headers#837
Merged
feat: update LineService.create to use JSON endpoint with version headers#837
Conversation
…ders
Migrate LineService.create() from the legacy form-urlencoded endpoint to the
JSON endpoint with X-Qminder-API-Version header. The new endpoint supports
additional fields: color, disabled, translations, and appointmentSettings.
BREAKING CHANGE: create() now accepts LineCreationRequest (with named colors)
instead of partial Line, and returns LineCreatedResponse ({ id: string })
instead of Line.
KonradPaluch
approved these changes
Mar 31, 2026
KonradPaluch
left a comment
KonradPaluch
left a comment
There was a problem hiding this comment.
works well
I also created a script to test it against live; I'll add it later today to GH
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LineService.create()from legacy form-urlencoded endpoint to JSON endpoint withX-Qminder-API-VersionheaderLineCreationRequest,LineCreatedResponse,LineColor,LineTranslation,LineAppointmentSettingscolor(named colors),disabled,translations,appointmentSettingsBreaking changes
create()acceptsLineCreationRequestinstead ofPartial<Line> & { name }— color is required, uses named values (TEAL,VIOLET, etc.)create()returnsLineCreatedResponse({ id: string }) instead ofLineTest plan