Skip to content

fix: replace any with proper timer types in GraphqlService#836

Open
2ndalpha wants to merge 1 commit intomasterfrom
fix/graphql-timer-any-types
Open

fix: replace any with proper timer types in GraphqlService#836
2ndalpha wants to merge 1 commit intomasterfrom
fix/graphql-timer-any-types

Conversation

@2ndalpha
Copy link
Copy Markdown
Member

@2ndalpha 2ndalpha commented Mar 26, 2026

Summary

  • Replace any type on pongTimeout and pingPongInterval with ReturnType<typeof setTimeout> | undefined and ReturnType<typeof setInterval> | undefined
  • Cross-environment idiomatic TypeScript approach (works in both Node.js and browser)
  • Type-only change, no runtime behavior affected

Test plan

  • yarn build succeeds
  • All 294 tests pass

@2ndalpha
fix: replace any with proper timer types in GraphqlService
4276fb4 
pongTimeout and pingPongInterval were typed as any. Use
ReturnType<typeof setTimeout/setInterval> for cross-environment
type safety.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@2ndalpha