Skip to content

fix: replace Promise<any> with SuccessResponse in line mutations #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2ndalpha merged 1 commit into from
Mar 30, 2026
Merged

fix: replace Promise<any> with SuccessResponse in line mutations #835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions packages/javascript-api/src/lib/services/line/line.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Line } from '../../model/line.js';
import { Location } from '../../model/location.js';
import { extractId, IdOrObject } from '../../util/id-or-object.js';
import { ApiBase } from '../api-base/api-base.js';
import { ApiBase, SuccessResponse } from '../api-base/api-base.js';

type LineCreateParameters = Partial<Omit<Line, 'id'>> & Pick<Line, 'name'>;
type LineUpdateParameters = Pick<Line, 'id'> &
Expand Down Expand Up @@ -45,7 +45,7 @@ export function create(
}) as Promise<Line>;
}

export function update(line: LineUpdateParameters): Promise<any> {
export function update(line: LineUpdateParameters): Promise<SuccessResponse> {
if (!line || typeof line !== 'object') {
throw new Error('Line is invalid or missing.');
}
Expand All @@ -69,57 +69,57 @@ export function update(line: LineUpdateParameters): Promise<any> {
return ApiBase.request(`v1/lines/${lineId}`, {
body: data,
method: 'POST',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}

export function enable(line: IdOrObject<Line>): Promise<any> {
export function enable(line: IdOrObject<Line>): Promise<SuccessResponse> {
const lineId = extractId(line);
if (!lineId || typeof lineId !== 'string') {
throw new Error('Line ID invalid or missing.');
}
return ApiBase.request(`v1/lines/${lineId}/enable`, {
method: 'POST',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}

export function disable(line: IdOrObject<Line>): Promise<any> {
export function disable(line: IdOrObject<Line>): Promise<SuccessResponse> {
const lineId = extractId(line);
if (!lineId || typeof lineId !== 'string') {
throw new Error('Line ID invalid or missing.');
}
return ApiBase.request(`v1/lines/${lineId}/disable`, {
method: 'POST',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}

export function archive(line: IdOrObject<Line>): Promise<any> {
export function archive(line: IdOrObject<Line>): Promise<SuccessResponse> {
const lineId = extractId(line);
if (!lineId || typeof lineId !== 'string') {
throw new Error('Line ID invalid or missing.');
}
return ApiBase.request(`v1/lines/${lineId}/archive`, {
method: 'POST',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}

export function unarchive(line: IdOrObject<Line>): Promise<any> {
export function unarchive(line: IdOrObject<Line>): Promise<SuccessResponse> {
const lineId = extractId(line);

if (!lineId || typeof lineId !== 'string') {
throw new Error('Line ID invalid or missing.');
}
return ApiBase.request(`v1/lines/${lineId}/unarchive`, {
method: 'POST',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}

export function deleteLine(line: IdOrObject<Line>): Promise<any> {
export function deleteLine(line: IdOrObject<Line>): Promise<SuccessResponse> {
const lineId = extractId(line);

if (!lineId || typeof lineId !== 'string') {
throw new Error('Line ID invalid or missing.');
}
return ApiBase.request(`v1/lines/${lineId}`, {
method: 'DELETE',
}) as Promise<any>;
}) as Promise<SuccessResponse>;
}
Loading