feat: add LocationService methods for setting opening hours#830
Merged
feat: add LocationService methods for setting opening hours#830
Conversation
Add setOpeningHours and setOpeningHoursExceptions to LocationService, enabling configuration of weekly opening hours and date-specific exceptions via the V2 API.
Follow the existing one-interface-per-file convention used throughout the model directory.
Use discriminated union types for DayOpeningHours and OpeningHoursException so the compiler rejects invalid combinations of closed and businessHours. Extract shared V2_HEADERS constant and tighten test stubs with withArgs.
KonradPaluch
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setOpeningHours(location, openingHours)method to configure weekly opening hours (mon-sun) for a locationsetOpeningHoursExceptions(location, exceptions)method to set date-specific exceptions (e.g., holidays)OpeningHours,DayOpeningHours,OpeningHoursRange,OpeningHoursTime,OpeningHoursExceptionPUTwithX-Qminder-API-Version: 2020-09-01header)Test plan
setOpeningHourswith numeric ID and object inputsetOpeningHoursExceptionswith numeric ID and object input