Fix AOT ?? compile lowering for superglobals (partial #148)#464
Open
PurHur wants to merge 1 commit into
Open
Conversation
Skip eager ArrayDimFetch before coalesce when php-cfg inserts ConstFetch between fetch and Coalesce; defer leftBlock scope inherit until after ISSET; avoid freeing the merge target before branch lowering; refresh endBlock scope after wiring branches. Pass dim operand into dimFetch for literal keys. Do not free coalesce result before branch JIT (issue #99). Remaining: coalesce_get_present.phpt still prints empty at AOT runtime (LLVM merge of branch assignments into coalesce result — see #148). Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ArrayDimFetchbefore??when php-cfg emits aConstFetch(e.g. default literal) between fetch andCoalesce(findsCoalesceUsingFetchAsLeft).leftBlockscope inheritance until afterISSETis lowered (avoids slot collision with the isset temp).freeDeadVariableson the coalesce branch block before LLVM branch lowering (merge target was freed early).endBlockscope after coalesce branches are wired.dimFetchfor compile-time string keys; exposeIssetHelper::literalStringKey.Test output (Docker
php-compiler:22.04-dev, tar pipe)Remaining failure (blocks merge for full #148)
Repro:
Tracked as the separate LLVM merge fix called out in commit e02df36 (
AOT/JIT coalesce on runtime superglobals remains a separate LLVM merge fix).Test plan
vendor/bin/phpunit --group aot-link --exclude-group servein Docker (117/118 pass)coalesce_get_present.phptAOT outputAda(still open)./script/ci-local.shin Docker when LLVM merge is fixedMade with Cursor