test(aot): 004-ApiJson compile+run and json_encode PHPT#393
Merged
Conversation
Shipped examples/004-ApiJson lacked AOT execute smoke beside lint-only gates. Add PHPT fixture, ExampleWebAotTest, and ExamplesCompileTest so bin/compile.php link+run is exercised for JSON API output. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test/fixtures/aot/cases/json_encode_api.phpt— AOT compile+run forheader,http_response_code(200), andjson_encode(issues Stdlib: json_encode and json_decode for API endpoints #61, Examples: 004-ApiJson — minimal JSON API endpoint (lint-first) #270).ExampleWebAotTestwithtestApiJsonExampleFileforexamples/004-ApiJson/example.php(matches 001/002 disk-based AOT coverage).ExamplesCompileTest::testAotExecuteSmoke004ApiJson—bin/compile.php -olink + execute smoke in the examples CI gate.docs/capabilities.md(json_encodenotes AOT PHPT).Test plan
Verified locally in Docker (
php-compiler:22.04-dev, harness tar-copy via./script/docker-ci-local.sh):New cases exercised:
AotTest→json_encode_apiPHPTExampleWebAotTest::testApiJsonExampleFileExamplesCompileTest::testAotExecuteSmoke004ApiJsonMade with Cursor