Stdlib: sprintf() for VM, JIT, and AOT#392
Merged
Merged
Conversation
Implement %s, %d, %f, and %% formatting without PHP internal wrappers: VmSprintf for the interpreter, __compiler_sprintf in the AOT runtime, and JitSprintf boxing for LLVM. Includes compliance and AOT PHPT coverage. Closes #89 Co-authored-by: Cursor <cursoragent@cursor.com>
PurHur
force-pushed
the
agent/stdlib-sprintf
branch
from
b0a9c84 to
a7abc2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sprintf()with documented subset:%s,%d,%f, and%%(no PHPinternal_*wrappers).VmSprintf; JIT/AOT call native__compiler_sprintfin the AOT runtime with boxed scalar args.sprintf.phpt,sprintf_jit.phpt) and AOT fixturesprintf.phpt; capability matrix updated.Closes #89
Test plan
vendor/bin/phpunit --filter sprintf test/compliance/(VM + compliance) — OK in Docker./script/docker-ci-local.sh --filter sprintf— docs/bootstrap checks + suite green./script/docker-ci-local.shon maintainer host (JIT probe may skip@group llvmif MCJIT malloc probe fails in container)Made with Cursor