Change default Asymptote method from server to local#1127
Conversation
Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/57b3c51d-7f85-4024-9514-b1082a883308
server to local
|
This looks good, but I think we need some tests for this to make sure it works. And please update the changelog to reflect the change. |
oscarlevin
left a comment
There was a problem hiding this comment.
Good, but needs tests and updates to changelog. @copilot, please revise.
Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/b107aac6-d62b-4650-a90e-ca20aaa6c619
Done in e17a340. Added assertions in |
oscarlevin
left a comment
There was a problem hiding this comment.
Tests are not passing. Probably because asy is not installed in the testing environment. @copilot, figure out how this can be fixed (perhaps by testing inside the pretextbook/pretext:latest devcontainer)
Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/a4c5f475-ee41-4903-89ed-fc37a07c1868
Fixed in 5a904b6. Added a |
* Initial plan * Change default Asymptote method from 'server' to 'local' Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/57b3c51d-7f85-4024-9514-b1082a883308 * Add tests for default asy_method and update CHANGELOG Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/b107aac6-d62b-4650-a90e-ca20aaa6c619 * Skip asy-dependent tests when asy is not installed Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com> Agent-Logs-Url: https://github.com/PreTeXtBook/pretext-cli/sessions/a4c5f475-ee41-4903-89ed-fc37a07c1868 --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: oscarlevin <6504596+oscarlevin@users.noreply.github.com>
asy_methodfromAsyMethod.SERVERtoAsyMethod.LOCALinpretext/project/__init__.pyasy_methodfrom"server"to"local"inpretext/project/xml.py(legacy format)templates/project.ptxandtemplates/course/project.ptxtest_defaultsandtest_manifest_simpleverifyingasy_methoddefaults toAsyMethod.LOCALCHANGELOG.mdwith aChangedentry under[Unreleased]HAS_ASYflag intests/test_cli.pyand skiptest_buildandtest_generate_graphicswhenasyis not installedHAS_ASYflag intests/test_sample_article.pyand skiptest_sample_articlewhenasyis not installedOriginal prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.