included set solution system#1335
Open
marcvanraalte wants to merge 12 commits intoPowerGridModel:feature/add_reduced_echelon_form_functionfrom
Open
included set solution system#1335marcvanraalte wants to merge 12 commits intoPowerGridModel:feature/add_reduced_echelon_form_functionfrom
marcvanraalte wants to merge 12 commits intoPowerGridModel:feature/add_reduced_echelon_form_functionfrom
Conversation
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
figueroa1395
added
feature
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
…/links-part-1 Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
Member
figueroa1395
left a comment
figueroa1395
left a comment
There was a problem hiding this comment.
Nice work. The comments are only minor things.
On the other hand, I also noticed that we don't really need the edge_history anymore, so maybe it's a good idea to think about removing it from EliminationResult. But this is just a thought. Let me know what you think (leaving it as-is is fine as well).
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/link_solver.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
Signed-off-by: marc van raalte <marc.van.raalte@alliander.com>
| dfs_matrix.set_value(matrix_element, pivot_edge_idx, dfs_matrix_col); | ||
| } | ||
| dfs_matrix.set_value(free_matrix_element, free_edge_idx, dfs_matrix_col); | ||
| extended_rhs[free_edge_indices[dfs_matrix_col]] = 0; |
Member
There was a problem hiding this comment.
I saw this again and I realized maybe this wasn't a smart decision to put it in the same loop.
Now we are assigning this a lot more times that we need to, since it in the inner loop. So we end up doing a bunch of additional work (adding a conditional even more). Also, it may help understand better the algorithm.
What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the functions:
to project the minimalization solution out of the set of solutions.