Unit test not observable network passed through no perturbation#1322
Open
Jerry-Jinfeng-Guo wants to merge 12 commits intomainfrom
Open
Unit test not observable network passed through no perturbation#1322Jerry-Jinfeng-Guo wants to merge 12 commits intomainfrom
Jerry-Jinfeng-Guo wants to merge 12 commits intomainfrom
Conversation
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds C++ unit tests around math_solver::observability::ObservabilityResult::use_perturbation() to ensure non-observable networks don’t trigger perturbation, and to exercise the use_perturbation boolean logic.
Changes:
- Added a new
TEST_CASEcoveringuse_perturbation()for a non-observable meshed network with multiple voltage phasor sensors. - Added additional subcases attempting to cover an observable case and direct
ObservabilityResultlogic combinations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
Signed-off-by: Jerry Jinfeng Guo <jerry.jinfeng.guo@alliander.com>
figueroa1395
reviewed
Mar 9, 2026
tests/data/state_estimation/meshed-network-observability/README.md
Outdated
Show resolved
Hide resolved
tests/data/state_estimation/meshed-network-observability/README.md
Outdated
Show resolved
Hide resolved
tests/data/state_estimation/meshed-network-observability/README.md
Outdated
Show resolved
Hide resolved
tests/data/state_estimation/meshed-network-observability/README.md
Outdated
Show resolved
Hide resolved
tests/data/state_estimation/meshed-network-observability/README.md
Outdated
Show resolved
Hide resolved
…sed-through-no-perturbation Signed-off-by: Jerry Guo <6221579+Jerry-Jinfeng-Guo@users.noreply.github.com>
…sed-through-no-perturbation
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
mgovers
reviewed
Mar 30, 2026
Comment on lines
+2028
to
+2034
| topo.sources_per_bus = {from_sparse, {0, 1, 1, 1, 1}}; | ||
| topo.shunts_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | ||
| topo.load_gens_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | ||
| topo.power_sensors_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | ||
| topo.power_sensors_per_source = {from_sparse, {0, 0}}; | ||
| topo.power_sensors_per_load_gen = {from_sparse, {0}}; | ||
| topo.power_sensors_per_shunt = {from_sparse, {0}}; |
Member
There was a problem hiding this comment.
why use from_sparse here instead of from_dense. To me, it reads much easier to just do
Suggested change
| topo.sources_per_bus = {from_sparse, {0, 1, 1, 1, 1}}; | |
| topo.shunts_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | |
| topo.load_gens_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | |
| topo.power_sensors_per_bus = {from_sparse, {0, 0, 0, 0, 0}}; | |
| topo.power_sensors_per_source = {from_sparse, {0, 0}}; | |
| topo.power_sensors_per_load_gen = {from_sparse, {0}}; | |
| topo.power_sensors_per_shunt = {from_sparse, {0}}; | |
| topo.sources_per_bus = {from_dense, {0}, 5}; | |
| topo.shunts_per_bus = {from_dense, {}, 5}; | |
| topo.load_gens_per_bus = {from_dense, {}, 5}; | |
| topo.power_sensors_per_bus = {from_dense, {}, 5}; | |
| topo.power_sensors_per_source = {from_dense, {}, 1}; | |
| topo.power_sensors_per_load_gen = {from_dense, {}, 0}; | |
| topo.power_sensors_per_shunt = {from_dense, {}}, 0; |
that is:
- 1 source at node 0 (out of a total of 5 nodes)
- no shunts (distributed over 5 nodes)
- no load gens (distributed over 5 nodes)
- no node injection power sensors (distributed over 5 nodes)
- no power sensors on sources (out of 1 source)
- no power sensors on load gens (there are no load gens)
- no power sensors on shunts (there are no shunts)
idem below
…sed-through-no-perturbation
Signed-off-by: Santiago Figueroa Manrique <figueroa1395@gmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added unit tests for checking the possibility to use perturbation due to observability check render
.is_observablestate without exception thrown.PR comes from #1317