Skip to content

chore: use shared semantic PR title workflow#123

Open
dustinbyrne wants to merge 1 commit into
mainfrom
chore/use-shared-semantic-pr-title-workflow
Open

chore: use shared semantic PR title workflow#123
dustinbyrne wants to merge 1 commit into
mainfrom
chore/use-shared-semantic-pr-title-workflow

Conversation

@dustinbyrne
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

PostHog/.github now provides a shared reusable workflow for validating PR titles against Conventional Commits. This switches the local SDK workflow to call that shared workflow, pinned to the merged .github workflow SHA, so the semantic PR title policy is centralized while each SDK repo still owns its PR trigger.

This supports the changelog flow because merged PR titles are used to determine changelog entries.

💚 How did you test it?

  • Parsed the updated workflow YAML locally with PyYAML.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • No changeset/Sampo entry needed for this CI-only change.

@dustinbyrne dustinbyrne requested review from a team and rafaeelaudibert as code owners May 27, 2026 18:47
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 27, 2026

Reviews (1): Last reviewed commit: "chore: use shared semantic PR title work..." | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

posthog-elixir Compliance Report

Date: 2026-05-27 18:49:33 UTC
Duration: 107335ms

⚠️ Some Tests Failed

42/45 tests passed, 3 failed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 610ms
Format Validation.Event Has Uuid 608ms
Format Validation.Event Has Lib Properties 608ms
Format Validation.Distinct Id Is String 609ms
Format Validation.Token Is Present 609ms
Format Validation.Custom Properties Preserved 609ms
Format Validation.Event Has Timestamp 608ms
Retry Behavior.Retries On 503 5615ms
Retry Behavior.Does Not Retry On 400 2611ms
Retry Behavior.Does Not Retry On 401 2612ms
Retry Behavior.Respects Retry After Header 5615ms
Retry Behavior.Implements Backoff 15625ms
Retry Behavior.Retries On 500 5615ms
Retry Behavior.Retries On 502 5614ms
Retry Behavior.Retries On 504 5613ms
Retry Behavior.Max Retries Respected 15626ms
Deduplication.Generates Unique Uuids 618ms
Deduplication.Preserves Uuid On Retry 5614ms
Deduplication.Preserves Uuid And Timestamp On Retry 10619ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 5615ms
Deduplication.No Duplicate Events In Batch 613ms
Deduplication.Different Events Have Different Uuids 611ms
Compression.Sends Gzip When Enabled 608ms
Batch Format.Uses Proper Batch Structure 608ms
Batch Format.Flush With No Events Sends Nothing 605ms
Batch Format.Multiple Events Batched Together 613ms
Error Handling.Does Not Retry On 403 2611ms
Error Handling.Does Not Retry On 413 2612ms
Error Handling.Retries On 408 5614ms

Feature_Flags Tests

⚠️ 13/16 tests passed, 3 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 8ms
Request Payload.Flags Request Uses V2 Query Param 6ms
Request Payload.Flags Request Hits Flags Path Not Decide 6ms
Request Payload.Flags Request Omits Authorization Header 7ms
Request Payload.Token In Flags Body Matches Init 6ms
Request Payload.Groups Round Trip 6ms
Request Payload.Groups Default To Empty Object 6ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 6ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 6ms
Request Payload.Disable Geoip Omitted Defaults To False 6ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 6ms
Request Lifecycle.No Flags Request On Init Alone 3ms
Request Lifecycle.No Flags Request On Normal Capture 607ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 10ms
Request Lifecycle.Mock Response Value Is Returned To Caller 6ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 608ms

Failures

request_payload.disable_geoip_omitted_defaults_to_false

Field 'geoip_disable' not found in /flags request body at path 'geoip_disable'. Available keys: ['groups', 'distinct_id', 'api_key', 'flag_keys_to_evaluate', 'group_properties', 'person_properties']

request_lifecycle.mock_response_value_is_returned_to_caller

Last action result missing field 'value'. Keys: ['error', 'success']

side_effect_events.get_feature_flag_captures_feature_flag_called_event

Expected 1 events with name '$feature_flag_called', got 0

Copy link
Copy Markdown
Member

@rafaeelaudibert rafaeelaudibert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Follow-up question: do we even need this action in this repo? AFAICT @Piccirello found a way to enable actions set in .github to run across ALL repositories around the app without requiring us to add them to each individual repo.

Can we follow that approach instead?

@Piccirello
Copy link
Copy Markdown
Member

Do we actually want this to run in every repo?

@dustinbyrne
Copy link
Copy Markdown
Contributor Author

dustinbyrne commented May 27, 2026

Follow-up question: do we even need this action in this repo? AFAICT @Piccirello found a way to enable actions set in .github to run across ALL repositories around the app without requiring us to add them to each individual repo.

Maybe, but this also feels reasonable enough to me given that:

  • it doesn't require an org admin to manage
  • the action exists in an expected location
  • and it's a relatively low-risk and lightweight validation (we just want to make sure we're not missing changelog items)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants