fix(error-tracking): always use arity when formatting stacktrace frames#122
Open
martosaur wants to merge 1 commit into
Open
fix(error-tracking): always use arity when formatting stacktrace frames#122martosaur wants to merge 1 commit into
martosaur wants to merge 1 commit into
Conversation
|
Reviews (1): Last reviewed commit: "fix(error-tracking): always use arity wh..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
This PR replaces #119
The problem is that PostHog Error Tracking uses resolved function name as part of the fingerprint for issue grouping. This is fine, but in Elixir SDK function name comes from the stacktrace frames, which are formatted using
Exception.format_mfa(module, function, arity_or_args).arity_or_argsis exactly that: arity or args. When it's arity, it's a simple integer that is stable across all calls. But when it's args, it's a dynamic value. So when included in the fingerprint, it prevents errors from grouping.The solution in this PR is to always use arity for formatting, even if we are passed arguments.
💚 How did you test it?
Unit and integration tests
📝 Checklist
If releasing new changes
sampo addto generate a changeset file