Add icons for types per game (#191)#199
Conversation
Thanks to Bulbapedia for hosting them
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
These PNGs embed an iCCP/ICC profile (iCCPICC profile). For sprite assets, this is typically unnecessary and adds size/noise across many files. Consider stripping ancillary metadata (iCCP/tEXt/zTXt/iTXt) via a lossless PNG optimizer (e.g., oxipng/pngcrush) so the repository stays smaller and assets are consistent.
There was a problem hiding this comment.
This asset includes a tEXtSoftware tag (Paint.NET v3.5.87) and other ancillary chunks. Consider stripping tool-identifying metadata across generated PNGs to keep builds reproducible and diffs stable (metadata frequently changes between export tools/versions even when pixels don’t).
| ��� | |
| IHDR��� ��� �������������sRGB���������gAMA������a���� cHRM��z&��������������u0���`��:����p��Q<��� pHYs����������(J�����IDAT8OŔ��� ��L�r���6RF��I����% |
There was a problem hiding this comment.
These PNG blobs are appearing in text diff form (showing �PNG plus control characters). To avoid any risk of line-ending normalization or accidental text conversions, ensure the repo enforces PNGs as binary (e.g., via .gitattributes with *.png -text or *.png binary). This helps keep assets intact and prevents noisy diffs.
|
Hi! Thanks for the PR! I see the point you are trying to solve. Honestly I wouldn't change the location of the existing images. So no need to put every image in a |
|
+1 please do not move existing images, as it can have impact on API consumers and our pipelines for generating the API endpoints. |
|
Thanks for the feedback, I definitely see the upsides with that, didn't really think about the API-side myself. Images now are where they were and |
|
Should we coerce all the small icons to same resolution to be consistent? they all seem to be squares so should be easily doable. Otherwise everything looks good imo :) |
|
Yes we should have them all with the same resolution. I'd downscale the bigger opnes to match the resolution of the smallest. For example, sprites/types/generation-vii/lets-go-pikachu-lets-go-eevee/small/13.png is smaller than 14.png |
|
Just to clarify, downscale all of the image to the smallest resolution being at 60x60 from 86x86/96x96/128x128? Will do that now, but some images might be noticeably squished. |
|
Okay i looked at the downscaled images, they look good to me. |
|
Hey just a quick note the 
I think this slipped by here https://github.com/PokeAPI/sprites/pull/139/changes can we you rename that folder to |
|
Actually i'm gonna undo it here and make a new issue. This deserves to be discussed differently, it's been like this for 1.5yrs and would potentially break 3rd party stuff like downloaders. |
|
If they were consuming it from pokeapi then they would just be getting |
Closes #191
As discussed in #191:
I moved already existing icons from
/sprites/types/{generation}/{game}/*.pngto[...]/{generation}/{game}/badges/*.pngand added[...]/icons/*.pngfor each game that has these icons.In this case, icons are purely the icons, and badges are icons with the type's name next to them. (Sometimes I just can't explain stuff properly so see the example below)
For games that do not have icons, I moved all images to
[...]/{generation}/{game}/badges/.