Add BW2 in-game trades#1524
Open
matthewchoy88 wants to merge 1 commit into
Open
Conversation
Adds the seven specific NPC trades from Pokémon Black 2 and White 2 (sourced from Serebii): - Route 4: Cottonee ↔ Petilil (version-exclusive) - Route 7: Emolga → Gigalith - Humilau City: Mantine → Tangrowth - Route 15: Ditto → Rotom - Accumula Town: Excadrill → Ambipom - Accumula Town: Hippowdon → Alakazam To support these: - Add encounter slot for the BW2 npc-trade method (vg 14, method 36) - Add Accumula Town location area (no entry existed) - Add seven new "Give X in a Trade" encounter condition values - Add encounters and encounter condition value mappings for B2 and W2 The Yancy/Curtis Funfest Mission trades in Nimbasa City are not included; they accept any Pokémon and depend on player gender, which needs additional encounter-condition infrastructure not present today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the seven specific NPC in-game trades from Pokémon Black 2 and White 2, sourced from Serebii.
Changes
Modeled on the existing GSC (#1473) and RSE (#1478) trade PRs:
encounter_slots.csv: new slot1482for the BW2 npc-trade method (vg 14, method 36).location_areas.csv/location_area_prose.csv: new location area1363for Accumula Town — no entry existed.encounter_condition_values.csv/encounter_condition_value_prose.csv: seven newtrade-<species>condition values (trade-cottonee,trade-petilil,trade-emolga,trade-mantine,trade-ditto,trade-excadrill,trade-hippowdon) with English prose.encounters.csv: 12 new encounter rows (6 per version) withmin_level= received level andmax_level= 100, following the convention from prior trade PRs.encounter_condition_value_map.csv: 12 new rows linking each encounter to its "give" condition.Out of scope
The Yancy/Curtis Funfest Mission trades in Nimbasa City are not included. They accept any Pokémon and branch on player gender, which would need new encounter-condition infrastructure (no
trade-anyor gender condition exists today). Happy to do these in a follow-up if there's interest.AI Declaration
Change was made with the help of an AI coding agent.
Contributor check list