Remove Onboarding feature flag#964
Draft
slifty wants to merge 10 commits into951-archive-name-fixfrom
Draft
Conversation
We were not reliably clearing out onboarding metadata when it finished or when users logged out, which meant that if the same browser was used to create two accounts there could be some contamination of the onboarding step for the second user. This (1) fixes that, and (2) moves the state management to the OnboardingService rather than an individual component. Issue #951 Ensure web archive name is empty during account creation
We had various components writing / reading session storage to look up onboarding flow information. This meant that the responsibility of concerns was fragmented and components were doing "more" than they really should have been responsible for. This moves the mechanism of storage / storage management entirely into the OnboardingService. It's now much easier to ensure things are behaving properly, and components have a much simpler API to interact with onboarding data. Issue #951 Ensure web archive name is empty during account creation
When a user logs out they might have some data in their session storage which should also be wiped away. Issue #951 Ensure web archive name is empty during account creation
The previous implementation of the onboarding flow interacted directly with local storage; however, we have a StorageService which exists to cover edge cases where local storage isn't actually available. This fix should make onboarding more robust, and is in line with the recent refactors to improve that storage.
Bumps [tar](https://github.com/isaacs/node-tar) from 7.5.9 to 7.5.10. - [Release notes](https://github.com/isaacs/node-tar/releases) - [Changelog](https://github.com/isaacs/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v7.5.9...v7.5.10) --- updated-dependencies: - dependency-name: tar dependency-version: 7.5.10 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [@hono/node-server](https://github.com/honojs/node-server) from 1.19.9 to 1.19.10. - [Release notes](https://github.com/honojs/node-server/releases) - [Commits](honojs/node-server@v1.19.9...v1.19.10) --- updated-dependencies: - dependency-name: "@hono/node-server" dependency-version: 1.19.10 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [hono](https://github.com/honojs/hono) from 4.12.3 to 4.12.5. - [Release notes](https://github.com/honojs/hono/releases) - [Commits](honojs/hono@v4.12.3...v4.12.5) --- updated-dependencies: - dependency-name: hono dependency-version: 4.12.5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
The old system had a wide variety of thumbnail sizes; we're moving to Archivematica for thumbnail processing and that will only generate a single thumb size. Old data will still have the old sizes, so our types do need to support them, but instead of accessing any given size directly we can leverage a `getThumbnail` and `getBanner` utility directly which will select the best size for the context given the available sizes for a given record (or folder). These functions will then inherently prefer the more modern approach. Issue #922 Use size 256 thumbnails
The thumbnail cache was trying to fit two concepts into one structure -- icons and multi-dimensional thumbnail arrays. This was awkward originally, but now that we are moving towards ditching the concept of a list of thumbnail types it really doesn't fit any longer. We can do better by having the cache store two types of thumbnails: icons and images. These are reflected explicitly now via TS interfaces.
Now that glam onboarding is live everywhere we no longer need the feature flag. Issue #959 Remove onboarding feature flag
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 951-archive-name-fix #964 +/- ##
========================================================
- Coverage 48.88% 48.79% -0.09%
========================================================
Files 350 345 -5
Lines 11363 11279 -84
Branches 1905 1896 -9
========================================================
- Hits 5555 5504 -51
+ Misses 5621 5585 -36
- Partials 187 190 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
slifty
force-pushed
the
951-archive-name-fix
branch
from
7dc5f94 to
b64de96
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the old onboarding code, meaning the new glam onboarding (which is already live everywhere) is the only onboarding we need to worry about going forward.
(this PR is a draft until the changes to onboarding are merged in #952)