Avoid unsafe graph cloning in calc path

src/Classes/Item.lua

@@ -1714,7 +1714,7 @@ function ItemClass:BuildModList()
 					end
 				end
 				for _, mod in ipairs(modLine.modList) do
-					mod = modLib.setSource(mod, self.modSource)
+					mod = modLib.withSource(mod, self.modSource)
 					baseList:AddMod(mod)
 				end
 				if modLine.modTags and #modLine.modTags > 0 then

src/Classes/ModStore.lua

@@ -32,6 +32,8 @@ local ModStoreClass = newClass("ModStore", function(self, parent)
 	self.actor = parent and parent.actor or { }
 	self.multipliers = { }
 	self.conditions = { }
+	-- ModDB/ModList instances participate in actor/parent graphs and are not plain copyTable() targets.
+	graphNodeTag(self, self._className or "ModStore")
 end)
 
 function ModStoreClass:ScaleAddMod(mod, scale, replace)
@@ -45,7 +47,7 @@ function ModStoreClass:ScaleAddMod(mod, scale, replace)
 	if scale == 1 or unscalable then
 		self:AddMod(mod)
 	else
-		local scaledMod = copyTable(mod)
+		local scaledMod = type(mod.value) == "table" and copyTableSafe(mod, false) or copyTable(mod)
 		local subMod = scaledMod
 		if type(scaledMod.value) == "table" then
 			if scaledMod.value.mod then
@@ -367,7 +369,7 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 				mult = 1 / mult
 			end
 			if type(value) == "table" then
-				value = copyTable(value)
+				value = copyTableSafe(value, false)
 				if value.mod then
 					value.mod.value = value.mod.value * mult + (tag.base or 0)
 					if limitTotal then
@@ -453,7 +455,7 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 				end 
 			end
 			if type(value) == "table" then
-				value = copyTable(value)
+				value = copyTableSafe(value, false)
 				if value.mod then
 					value.mod.value = value.mod.value * mult + (tag.base or 0)
 					if limitTotal then
@@ -502,7 +504,7 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 				end 
 			end
 			if type(value) == "table" then
-				value = copyTable(value)
+				value = copyTableSafe(value, false)
 				if value.mod then
 					value.mod.value = m_ceil(value.mod.value * mult + (tag.base or 0))
 					if limitTotal then
@@ -901,4 +903,4 @@ function ModStoreClass:EvalMod(mod, cfg, globalLimits)
 		end
 	end
 	return value
-end
+end

src/Classes/PassiveSpec.lua

@@ -2162,7 +2162,7 @@ function PassiveSpecClass:NodeAdditionOrReplacementFromString(node,sd,replacemen
 	for _, mod in pairs(addition.mods) do
 		if mod.list and not mod.extra then
 			for i, mod in ipairs(mod.list) do
-				mod = modLib.setSource(mod, "Tree:"..node.id)
+				mod = modLib.withSource(mod, "Tree:"..node.id)
 				addition.modList:AddMod(mod)
 			end
 		end

src/Classes/PassiveTree.lua

@@ -791,7 +791,7 @@ function PassiveTreeClass:ProcessStats(node, startIndex)
 		local mod = node.mods[i]
 		if mod.list and not mod.extra then
 			for i, mod in ipairs(mod.list) do
-				mod = modLib.setSource(mod, "Tree:"..node.id)
+				mod = modLib.withSource(mod, "Tree:"..node.id)
 				node.modList:AddMod(mod)
 			end
 		end

src/Data/Skills/sup_str.lua

@@ -2493,8 +2493,8 @@ skills["AvengingFlame"] = {
 	castTime = 1,
 	preDamageFunc = function(activeSkill, output)
 		local uuid = activeSkill.skillData.triggerSourceUUID
-		local cache = uuid and (GlobalCache.cachedData["MAIN"][uuid] or GlobalCache.cachedData["CALCS"][uuid])
-		local totemLife = cache and cache.Env.player.output.TotemLife or 0
+		local cache = uuid and (getGlobalCacheTable("MAIN")[uuid] or getGlobalCacheTable("CALCS")[uuid])
+		local totemLife = cache and cache.Output.TotemLife or 0
 
 		local add = totemLife * activeSkill.skillData.lifeDealtAsFire / 100
 		activeSkill.skillData.FireMax = (activeSkill.skillData.FireMax or 0) + add
@@ -5575,4 +5575,4 @@ skills["SupportExpertRetaliation"] = {
 		[39] = { 107, 53, levelRequirement = 99, manaMultiplier = 30, statInterpolation = { 1, 1, }, },
 		[40] = { 108, 54, levelRequirement = 100, manaMultiplier = 30, statInterpolation = { 1, 1, }, },
 	},
-}
+}

src/Export/Skills/sup_str.txt

@@ -338,8 +338,8 @@ local skills, mod, flag, skill = ...
 #skill AvengingFlame
 	preDamageFunc = function(activeSkill, output)
 		local uuid = activeSkill.skillData.triggerSourceUUID
-		local cache = uuid and (GlobalCache.cachedData["MAIN"][uuid] or GlobalCache.cachedData["CALCS"][uuid])
-		local totemLife = cache and cache.Env.player.output.TotemLife or 0
+		local cache = uuid and (getGlobalCacheTable("MAIN")[uuid] or getGlobalCacheTable("CALCS")[uuid])
+		local totemLife = cache and cache.Output.TotemLife or 0
 
 		local add = totemLife * activeSkill.skillData.lifeDealtAsFire / 100
 		activeSkill.skillData.FireMax = (activeSkill.skillData.FireMax or 0) + add
@@ -796,4 +796,4 @@ local skills, mod, flag, skill = ...
 			mod("CooldownRecovery", "MORE", nil),
 		},
 	},
-#mods
+#mods