Skip to content

Fix stack trace formatter mangling exception messages #2919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnsimons merged 6 commits into from
Mar 30, 2026
Merged

Fix stack trace formatter mangling exception messages #2919

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
302cf36
🐛 Fix stack trace formatter mangling exception messages
dvdstelt Mar 24, 2026
fa0c713
Refactor stack trace formatter and add unit tests
johnsimons Mar 24, 2026
d7949d0
🐛 Fix lineNumber type to match runtime string value
dvdstelt Mar 25, 2026
7002af4
🐛 Fix zero-arg frames producing phantom param entry
dvdstelt Mar 25, 2026
2f1d0df
✨ Replace type assertion with satisfies for compile-time safety
dvdstelt Mar 25, 2026
5f01cf9
⚜️ Correct inaccurate test comments about regex behavior
dvdstelt Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 2 additions & 91 deletions src/Frontend/src/components/messages/StacktraceFormatter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<script lang="ts" setup>
import { ref, watch } from "vue";
import { type Language, type StackTraceElement, languages, detectLanguagesInOrder, formatStackTrace } from "./StacktraceFormatter/stacktraceFormatter";

// Define TypeScript interfaces for settings and supported languages
interface NetStackOptions {
Expand All @@ -13,26 +14,6 @@ interface NetStackOptions {
line?: string;
}

interface Language {
name: string;
at: string;
in: string;
line: string;
}

type Text = string;

interface Node {
params: Array<{ name: string; type: string }>;
type: string;
lineNumber?: number;
file?: string;
method: string;
spaces: string;
}

type Element = Text | Node;

// Props
const props = withDefaults(defineProps<{ stackTrace: string; options?: NetStackOptions }>(), {
options: () => ({
Expand All @@ -47,80 +28,10 @@ const props = withDefaults(defineProps<{ stackTrace: string; options?: NetStackO
}),
});

// Supported languages and their keywords
const languages: Language[] = [
{ name: "english", at: "at", in: "in", line: "line" },
{ name: "danish", at: "ved", in: "i", line: "linje" },
{ name: "german", at: "bei", in: "in", line: "Zeile" },
{ name: "spanish", at: "en", in: "en", line: "línea" },
{ name: "russian", at: "в", in: "в", line: "строка" },
{ name: "chinese", at: "在", in: "位置", line: "行号" },
];

// Reactive variables and setup state
const formattedStack = ref<Element[]>([]);
const formattedStack = ref<StackTraceElement[]>([]);
const selectedLanguage = ref<Language>(languages[0]);

// Helper function to detect languages in the stack trace
const detectLanguagesInOrder = (text: string): Language[] => {
const languageRegexes = {
english: /\s+at .*?\)/g,
danish: /\s+ved .*?\)/g,
german: /\s+bei .*?\)/g,
spanish: /\s+en .*?\)/g,
russian: /\s+в .*?\)/g,
chinese: /\s+在 .*?\)/g,
};

const detectedLanguages: Language[] = [];
for (const lang in languageRegexes) {
if (languageRegexes[lang as keyof typeof languageRegexes].test(text)) {
const foundLang = languages.find((l) => l.name === lang);
if (foundLang) {
detectedLanguages.push(foundLang);
}
}
}

return detectedLanguages;
};

// Core formatting logic
const formatStackTrace = (stackTrace: string, selectedLang: Language): Element[] => {
const lines = stackTrace.split("\n");
const fileAndLineNumberRegEx = new RegExp(`${selectedLang.in} (.+):${selectedLang.line} (\\d+)`);
const atRegex = new RegExp(`(\\s*)(${selectedLang.at}) (.+?)\\((.*?)\\)`);

return lines.map((line) => {
const match = line.match(atRegex);
if (match) {
const [, spaces, , methodWithType, paramsWithFile] = match;

const [type, method] = (() => {
const parts = methodWithType.split(".");
const method = parts.pop() ?? "";
const type = parts.join(".");
return [type, method];
})();

const params = paramsWithFile.split(", ").map((param) => {
const [paramType, paramName] = param.split(" ");
return { name: paramName, type: paramType };
});

const matchFile = line.match(fileAndLineNumberRegEx);
let file, lineNumber;
if (matchFile) {
[, file, lineNumber] = matchFile;
}

return <Node>{ method, type, params, file, lineNumber, spaces };
} else {
return line;
}
});
};

// Process the provided stack trace
const processStackTrace = (): void => {
const rawContent = props.stackTrace;
Expand Down
Loading