Skip to content

Relax metadata requirements #2547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fluidnumerics-joe merged 1 commit into from
Mar 17, 2026
Merged

Relax metadata requirements #2547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/parcels/_core/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,21 +144,21 @@
@property
def xdim(self):
if type(self.data) is xr.DataArray:
return self.grid.xdim

Check failure on line 147 in src/parcels/_core/field.py

View workflow job for this annotation

GitHub Actions / TypeChecking: pixi run typing

ty (unresolved-attribute) 

src/parcels/_core/field.py:147:20: unresolved-attribute: Attribute `xdim` is not defined on `UxGrid` in union `Unknown | UxGrid | XGrid`
  info: rule `unresolved-attribute` is enabled by default
else:
raise NotImplementedError("xdim not implemented for unstructured grids")

@property
def ydim(self):
if type(self.data) is xr.DataArray:
return self.grid.ydim

Check failure on line 154 in src/parcels/_core/field.py

View workflow job for this annotation

GitHub Actions / TypeChecking: pixi run typing

ty (unresolved-attribute) 

src/parcels/_core/field.py:154:20: unresolved-attribute: Attribute `ydim` is not defined on `UxGrid` in union `Unknown | UxGrid | XGrid`
  info: rule `unresolved-attribute` is enabled by default
else:
raise NotImplementedError("ydim not implemented for unstructured grids")

@property
def zdim(self):
if type(self.data) is xr.DataArray:
return self.grid.zdim

Check failure on line 161 in src/parcels/_core/field.py

View workflow job for this annotation

GitHub Actions / TypeChecking: pixi run typing

ty (unresolved-attribute) 

src/parcels/_core/field.py:161:20: unresolved-attribute: Attribute `zdim` is not defined on `UxGrid` in union `Unknown | UxGrid | XGrid`
  info: rule `unresolved-attribute` is enabled by default
else:
if "nz1" in self.data.dims:
return self.data.sizes["nz1"]
Expand Down Expand Up @@ -418,15 +418,6 @@
"This attribute is required for xarray.DataArray objects."
)

# Validate attributes
required_keys = ["location", "mesh"]
for key in required_keys:
if key not in data.attrs.keys():
raise ValueError(
f"Field is missing a '{key}' attribute in the field's metadata. "
"This attribute is required for xarray.DataArray objects."
)


def _assert_compatible_combination(data: xr.DataArray | ux.UxDataArray, grid: UxGrid | XGrid):
if isinstance(data, ux.UxDataArray):
Expand Down
Loading