Skip to content

Fix warnings #475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dweindl wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix warnings #475

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion petab/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,15 @@ def __getattr__(name):
return importlib.import_module("petab.v1")
if name == "v2":
return importlib.import_module("petab.v2")
if name not in ("__path__", "__all__", "__wrapped__"):
if name not in (
"__path__",
"__all__",
"__wrapped__",
# accessed under pytest
"_pytestfixturefunction",
"__test__",
"__bases__",
):
warn(
f"Accessing `petab.{name}` is deprecated and will be removed in "
f"the next major release. Please use `petab.v1.{name}` instead.",
Expand Down
4 changes: 2 additions & 2 deletions petab/v2/petab1to2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ def update_prior(row):
if new_prior_type == "log10-normal":
warnings.warn(
f"Prior distribution `{new_prior_type}' for parameter "
f"`{row.name}' is not supported in PEtab v2. "
f"`{row[v1.C.PARAMETER_ID]}' is not supported in PEtab v2. "
"Using `log-normal` instead.",
# call to `petab1to2`
stacklevel=9,
Expand All @@ -504,7 +504,7 @@ def update_prior(row):
if new_prior_type not in v2.C.PRIOR_DISTRIBUTIONS:
raise NotImplementedError(
f"PEtab v2 does not support prior type `{new_prior_type}' "
f"required for parameter `{row.name}'."
f"required for parameter `{row[v1.C.PARAMETER_ID]}'."
)

return new_prior_type
Expand Down