Mocks & New IRoboCommand for non-windows platforms#217
Draft
RFBomb wants to merge 11 commits intoPCAssistSoftware:devfrom
Draft
Mocks & New IRoboCommand for non-windows platforms#217RFBomb wants to merge 11 commits intoPCAssistSoftware:devfrom
RFBomb wants to merge 11 commits intoPCAssistSoftware:devfrom
Conversation
- This new IRoboCommand utilizes the IFileCopierFactory to perform copy operations without creating a new RoboCopy process. This allows full control over the actual copy operation if desired, and allows for cross-platform targeting if needed. - Added IAuthenticator to allow customization of the FactoryCommand's authentication prior to starting the command. By default simply verifies it can access source and destination. - Adjusted helpers and extension methods as needed.
Owner
|
nice, I will keep following the progress of these changes. Thanks Robert |
- Since this new IRoboCommand is designed to be portable between platforms, the class name has been updated to reflect that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I required some mocks for my project, so I opted to add them into the Extensions package.
To make best use of the mocks, I'm also creating a new IRoboCommand to fully simulate the actions of RoboCopy via the IFileCopierFactory interfaces that were introduced a while back. This would allow full control of the copy and logging process by consumers that want it, and should also allow for cross-platform usage via custom IFileCopiers (like the StreamedFileCopier)
This is still WIP, as its not passing all unit tests 1:1 with robocopy, but a chunk of them are functional.