Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
|
Coverage report for commit: 0be9f9f Summary - Lines: 100.00% 🔼 | Methods: 100.00% ⏹️ | Branches: 97.22% 🔼
🤖 comment via lucassabreu/comment-coverage-clover |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
yevdyko
left a comment
There was a problem hiding this comment.
@jamesrweb There are a few merge conflicts in the PR. I think we’ll be able to merge it once they’ve been resolved. WDYT?
Yes, I will resolve the conflicts today - it happened due to the other two PRs being merged. 👍🏻 |
|
FYI @yevdyko, I changed the name of the base branch to |
yevdyko
left a comment
There was a problem hiding this comment.
Looks good, except that the package includes a duplicate in the way of an older version of Vite
Thank you @jamesrweb
Related Issue
N/A — workflow overhaul to fix bugs, improve security, and reduce duplication
PR Type
Description
Overhaul all GitHub Actions workflows to fix several bugs, eliminate duplication
via a reusable composite action, tighten security with scoped permissions,
simplify caching with
actions/setup-nodebuilt-in support, and centraliseNode/pnpm version management through
package.json.Proposed Changes
.github/actions/setup/action.ymlcomposite action that handles pnpmsetup, Node.js installation (reading version from
package.json), built-inpnpm caching via
actions/setup-node, and dependency installation — replacingthe 5–7 duplicated steps across every job in every workflow
setupjob that spun up a full runner just to compute cachekeys
broken: job status stayed "failure" after fix, downstream jobs were skipped,
and
GITHUB_TOKENcommits don't re-trigger CI)branch protection enforces all must pass
{{ matrix.runs-on }}in artifact names — was literal text (missing$prefix) and no matrix strategy existednpm-dry-runjob to properly download build artifacts (removedcontinue-on-errorthat silently swallowed download failures)successful CI run via
gh apiandrun-idparameter, instead of attemptingto download from the current run (which always failed)
lucassabreu/comment-coverage-clovertov0.16.0instead of@mainpermissions: {}at workflow level with least-privilege per-job scopingcontents: writefrom format and lint jobs (no longer needed withoutauto-commit)
gh-pagesandnpmjobs now run in parallel (removed unnecessarydependency)
cancel-in-progresstofalseto prevent aborting mid-deployto master
pnpm publishwithJS-DevTools/npm-publish@v4for built-inversion-exists checking and provenance support
environment: productionto the npm publish job for environmentprotection rules
permissions: {}at workflow level with least-privilege per-job scoping["javascript", "typescript"]matrix(which ran two identical scans) with single
javascript-typescriptlanguagefetch-depth: 0(CodeQL doesn't need full git history)categoryto the analyze steppermissions: {}at workflow levelfixes and commits only happen when checks actually fail
permissions: {}at workflow levelPR_DESCRIPTION.mdto.gitignoreHow Has This Been Tested?
Workflow YAML validated for correct syntax and structure. CI run on this PR will
serve as the functional validation.
Screenshots/Recordings
N/A — no visual changes.
Breaking Changes
Checklist
Additional Notes
The CD workflow now uses
JS-DevTools/npm-publish@v4instead of rawpnpm publish. This action automatically skips publishing when the versionalready exists on the registry, preventing failures on non-version-bump pushes
to master.
A new
environment: productionhas been added to the npm publish job. You mayneed to create this environment in the repository settings and configure any
desired protection rules (e.g. required reviewers).
The auto-fix-and-commit pattern has been removed from CI. Developers should run
pnpm formatandpnpm lint:fixlocally before pushing. The Dependabotworkflow retains its auto-fix pattern since Dependabot PRs cannot be edited
manually.