[REFACTOR](core) Convert StrippedConstraint to PatternConstraint subclass#466
Merged
Victor Schappert (vcschapp) merged 1 commit intodevfrom Mar 11, 2026
Merged
Conversation
StrippedConstraint now extends PatternConstraint, using the same constructor as every other concrete constraint. Custom validate() and __get_pydantic_json_schema__() eliminated. Uses \Z (absolute end-of-string) instead of $ because Python's $ matches before a trailing \n. JSON schema emission swaps \Z back to $ since ECMA regex treats $ as absolute end-of-string. Signed-off-by: Seth Fitzsimmons <sethfitz@amazon.com>
Seth Fitzsimmons (sethfitz)
requested a review
from Victor Schappert (vcschapp)
Victor Schappert (vcschapp)
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StrippedConstraint now extends PatternConstraint, using the same constructor as every other concrete constraint. Custom
validate()and__get_pydantic_json_schema__()eliminated. Codegen extracts the regex viaconstraint.pattern.pattern.Uses
\Z(absolute end-of-string) instead of$because Python's$matches before a trailing\n, which would let strings like"hello\n"pass validation. JSON schema emission swaps\Zback to$since ECMA regex treats$as absolute end-of-string.