Await GAID before targeting and identify #38
Open
ValentinPostindustria wants to merge 3 commits intomasterfrom
Open
Await GAID before targeting and identify #38ValentinPostindustria wants to merge 3 commits intomasterfrom
ValentinPostindustria wants to merge 3 commits intomasterfrom
Conversation
zapo
reviewed
Mar 20, 2026
| var containsCustomGaid = false | ||
| val googleAdId = googleAdIdManager.getId() | ||
| if (googleAdId != null) { | ||
| result.addIfNotNull(GAID, googleAdId, ::trim) |
Member
There was a problem hiding this comment.
Should we ::normalize here as well similarly to what we do for user provided GAID?
zapo
reviewed
Mar 20, 2026
| is OptableIdentifier.GoogleGaid -> { | ||
| result.addIfNotNull(GAID, identifier.value, ::normalize) | ||
| containsCustomGaid = true | ||
| if (googleAdId == null) { |
Member
There was a problem hiding this comment.
I see the requirements in #37 states we should override the user provided value with system detected, but I thought we were going to keep both, cc @jrosendahl-opt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37.