Accept truncations in pops smaller than 16#740
Open
wvpm wants to merge 1 commit into
Open
Conversation
schombert
reviewed
May 19, 2026
| template<bool IsTaxable> | ||
| void Pop::add_artisanal_revenue(const fixed_point_t revenue) { | ||
| if (OV_unlikely(revenue == 0)) { | ||
| if (OV_unlikely(revenue == 0 && size >= TRUNCATION_ACCEPTABLE_BELOW_SIZE)) { |
There was a problem hiding this comment.
are you sure that you didn't mean <= ? (this applies below as well)
(and maybe || as well)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Truncations are bound to happen with fixed point math. At a certain pop size we just have to accept it to avoid spamming warnings.