Restore custom URL scheme in mobile deep-link config#449
Open
AnthonyRonning wants to merge 1 commit intomasterfrom
Open
Restore custom URL scheme in mobile deep-link config#449AnthonyRonning wants to merge 1 commit intomasterfrom
AnthonyRonning wants to merge 1 commit intomasterfrom
Conversation
The cloud.opensecret.maple custom scheme entry was accidentally removed from the mobile config in 9e6a5a2 when fixing Android pathPrefix. This tells the deep-link plugin to preserve CFBundleURLTypes in Info.plist for iOS, complementing the build.rs workaround. Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds a new mobile deep-link scheme entry to the Tauri configuration, registering the custom scheme Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds back the
cloud.opensecret.maplecustom scheme entry to the mobile deep-link config. This was accidentally removed in 9e6a5a2 (Dec 2, 2025) when fixing Android pathPrefix restrictions.Without this entry, the Tauri deep-link plugin's
build.rssees no non-app-link mobile domains and stripsCFBundleURLTypesfrom Info.plist, removing the custom URL scheme registration needed for iOS OAuth redirect.The previous PR (build.rs workaround) is a safety net; this is the proper config-level fix. Does not affect Android -- custom schemes without a host don't generate intent filters.
Summary by CodeRabbit
Release Notes