[ana6, com8]: Add ana6Optimisation Module, apply changes in com8MoTPSA by RolandFischbacher · Pull Request #1245 · OpenNHM/AvaFrame

RolandFischbacher · 2026-02-23T17:47:10Z

This PR introduces a new optimisation module ana6Optimisation for com8MoTPSA and updates the simulation workflow.

The module ana6Optimisation includes:

Calculation of combined loss function (runout + tversky)
Morris sensitivity analysis for parameter ranking
Sequential and non-sequential surrogate based optimisation routines

New files in ana6Opitmisaton:

runMorrisSA.py (configuration: runMorrisSACfg.ini)
runPlotMorrisConvergence.py (uses runMorrisSACfg.ini)
runOptimisation.py (configuration: runOptimisationCfg.ini)
optimisationUtils.py
README_ana6.md (contains usage instructions)

New file in out3Plot:

outAna6Plots.py

Changed workflow of runing com8MoTPSA:

Check prior if simulation is run already
Process in chunks not all simulations at once

qltysh · 2026-02-23T17:48:47Z

❌ 2 blocking issues (5 total)

Tool	Category	Rule	Count
black	Style	Incorrect formatting, autoformat by running `qlty fmt`.	1	❌
ruff	Lint	Local variable `results` is assigned to but never used	1	❌
qlty	Structure	Deeply nested control flow (level = 4)	2
qlty	Structure	Function with high complexity (count = 15): BOConvergencePlot	1

@qltysh one-click actions:

Auto-fix formatting (qlty fmt && git push)

avaframe/ana3AIMEC/aimecTools.py

avaframe/ana6Optimisation/README_ana6.md

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/out3Plot/outAna6Plots.py

qltysh · 2026-02-23T17:48:49Z

avaframe/out3Plot/outAna6Plots.py

+    # 4) Plot
+    x = np.arange(len(df))
+    fig, ax = plt.subplots(figsize=(12, 6))
+    bars = ax.bar(


Local variable bars is assigned to but never used [ruff:F841]

Suggested change

bars = ax.bar(

ax.bar(

avaframe/out3Plot/outAna6Plots.py

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/out3Plot/outAna6Plots.py

avaframe/ana3AIMEC/aimecTools.py

avaframe/ana3AIMEC/ana3AIMEC.py

avaframe/out3Plot/outQuickPlot.py

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/ana3AIMEC/aimecTools.py

avaframe/ana6Optimisation/README_ana6.md

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/com8MoTPSA/com8MoTPSA.py

avaframe/out1Peak/outPlotAllPeakDiffs.py

avaframe/out3Plot/outAIMEC.py

Squash of 20 commits from RF_com8MoTPSA branch including: - com8MoTPSA workflow improvements (chunked multiprocessing, path handling) - Bayesian optimisation integration (ana6Optimisation module) - Morris sensitivity analysis scripts - AIMEC runout reference implementation - probAna pickle saving and bounds - Plotting and config improvements

avaframe/ana6Optimisation/optimisationUtils.py

avaframe/com8MoTPSA/com8MoTPSA.py

qltysh · 2026-02-24T14:41:27Z

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.19%.

Modified Components (1)

Rating	Component	% Diff
	com1DFA	—

Modified Files with Diff Coverage (2)

File	% Diff	Uncovered Line #s
avaframe/com8MoTPSA/com8MoTPSA.py	0.0%	21-182
avaframe/in3Utils/cfgUtils.py	71.4%	995, 1016
Total	10.0%

🤖 Increase coverage with AI coding...

In the `RF_com8MoTPSA` branch, add test coverage for this new code:

- `avaframe/com8MoTPSA/com8MoTPSA.py` -- Line 21-182
- `avaframe/in3Utils/cfgUtils.py` -- Lines 995 and 1016

🚦 See full report on Qlty Cloud »

🛟 Help

Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.
Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.
File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)
- Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

avaframe/runScripts/runPlotAreaRefDiffs.py

…s and checks

avaframe/out3Plot/outAna6Plots.py

- Add bounds to paramValuesD in createSamplesWithVariation (StandardParameters) - Add writing of visualisation scenario and sampling method to com8MoTPSACfg.ini

avaframe/out3Plot/outAna6Plots.py

…bles

avaframe/out3Plot/outAna6Plots.py

fso42 · 2026-02-26T10:00:39Z

avaframe/ana6Optimisation/optimisationUtils.py

@@ -0,0 +1,886 @@
+import numpy as np


A general note for this file: use log.info instead of prints for user info

avaframe/ana6Optimisation/optimisationUtils.py

fso42 · 2026-02-26T10:05:07Z

avaframe/ana6Optimisation/optimisationUtils.py

+    return xBest, xBestDict, np.max(ei), np.max(lcb)
+
+
+def runCom8MoTPSA(avalancheDir, xBestDict, cfgMain, i=0, optimisationType=None):


I think this could be solved differently, as it duplicates code that might be changed. Investigate if a direct call with updated cfgs would be better. Let me now if you need help

Implemented a direct call of com8MoTPSAMain with updated cfgs (writeCfgFiles in optimisationUtils.py)

fso42 · 2026-02-26T10:36:05Z

avaframe/ana6Optimisation/optimisationUtils.py

+            if 'VISUALISATION' in config.sections():
+                # config is inifile
+                index = config['VISUALISATION']['scenario']
+
+                if 'VISUALISATION' in config.sections():
+                    # config is inifile
+                    index = config['VISUALISATION']['scenario']
+                    if 'sampleMethod' in config['VISUALISATION']:
+                        sampleMethod = config['VISUALISATION']['sampleMethod']


if any .ini file in the config directory lacks a VISUALISATION section, the variables index and sampleMethod are never assigned, but they are unconditionally appended on lines 107-108. On the first such file, this raises UnboundLocalError. Even if subsequent iterations reuse a stale value from a previous file, the data would be silently wrong.

Thank you for the info. I will initialize index and sampleMethod with np.nan to avoid UnboundLocalError and stale values.

fso42 · 2026-02-26T10:36:48Z

avaframe/ana6Optimisation/optimisationUtils.py

+                # config is inifile
+                index = config['VISUALISATION']['scenario']
+
+                if 'VISUALISATION' in config.sections():


Why the duplicate if? Copy/Paste error?

Yes copy paste error.

fso42 · 2026-02-26T10:38:30Z

avaframe/ana4Stats/probAna.py

+            if modName.lower() in ["com1dfa", "com5snowslide", "com6rockavalanche", 'com8motpsa']:
                cfgStart["VISUALISATION"]["scenario"] = str(count1)
                cfgStart["INPUT"]["thFromIni"] = paramValuesD["thFromIni"]
+                cfgStart["VISUALISATION"]["sampleMethod"] = cfg['PROBRUN']['sampleMethod']


The new line cfgStart["VISUALISATION"]["sampleMethod"] = cfg['PROBRUN']['sampleMethod'] reads sampleMethod from cfg['PROBRUN'].

However, probAnaCfg.ini has sampleMethod under [PROBRUN] only when probAna is the caller. If createCfgFiles is called from a different path where cfg doesn't have PROBRUN.sampleMethod, this will raise KeyError. The code also assumes VISUALISATION section exists in cfgStart for com8MoTPSA — while the new com8MoTPSACfg.ini does add it, there's no sampleMethod default there, making the flow dependent on the caller always providing this key.

Added check if 'VISUALISATION' exists in cfgStart, if not, it will be added to cfgStart.
And read sample method with fallback; meaning if 'PROBANA' or 'sampleMethod' is missing sample_method contains an empty string.

avaframe/ana6Optimisation/runOptimisation.py

avaframe/ana6Optimisation/optimisationUtils.py

…i file, delete redundant code

…ameCfg.ini nCPU

…Files in optimisationUtils.py), add possibility to RUN writeCfgFiles with counter

…clean header Implement modName to make code general and remove adjustText package

…ror and stale values and remove copy paste error.

… added to cfgStart. And read sample method with fallback; meaning if 'PROBANA' or 'sampleMethod' is missing sample_method contains an empty string

qltysh · 2026-02-28T18:05:12Z

avaframe/ana4Stats/probAna.py

-            if modName.lower() in ["com1dfa", "com5snowslide", "com6rockavalanche"]:
+            if modName.lower() in ["com1dfa", "com5snowslide", "com6rockavalanche", 'com8motpsa']:
+                # Check if visualisation exists in cfgStart, if not add the section
+                if not cfgStart.has_section("VISUALISATION"):


Deeply nested control flow (level = 4) [qlty:nested-control-flow]

avaframe/ana6Optimisation/optimisationUtils.py

qltysh · 2026-02-28T18:05:13Z

avaframe/ana6Optimisation/optimisationUtils.py

+                index = config['VISUALISATION']['scenario']
+                if 'sampleMethod' in config['VISUALISATION']:
+                    sampleMethod = config['VISUALISATION']['sampleMethod']
+                else:


Deeply nested control flow (level = 4) [qlty:nested-control-flow]

qltysh · 2026-02-28T18:05:13Z

avaframe/com8MoTPSA/com8MoTPSA.py

+        nCPU = cfgUtils.getNumberOfProcesses(cfgMain, len(rcfFilesChunk))
+
+        with Pool(processes=nCPU) as pool:
+            results = pool.map(com8MoTPSATask, rcfFilesChunk)


Local variable results is assigned to but never used [ruff:F841]

Suggested change

results = pool.map(com8MoTPSATask, rcfFilesChunk)

pool.map(com8MoTPSATask, rcfFilesChunk)

… docstring, tidy up code, add if __name__='__main__': in runPlotMorrisConvergence.py and improve BOConvergencePlot.

qltysh · 2026-03-02T14:24:57Z

avaframe/out3Plot/outAna6Plots.py

+    # Save figure
+    date = datetime.now().strftime("%Y%m%d")
+    figName = f"{outDir}/{avaName}_BOConvergence_{initial_label}_{date}.png"
+    fig.savefig(figName, dpi=300, bbox_inches="tight")


Function with high complexity (count = 15): BOConvergencePlot [qlty:function-complexity]

RolandFischbacher requested review from awirb and fso42 February 23, 2026 17:47

RolandFischbacher self-assigned this Feb 23, 2026

RolandFischbacher added the enhancement New feature or request label Feb 23, 2026

qltysh bot reviewed Feb 23, 2026

View reviewed changes

fso42 added this to the Version 2.0 milestone Feb 23, 2026

fso42 changed the title ~~[ana6Opitmisation], [com8MoTPSA]: Add ana6Optimisation Module, apply changes in com8MoTPSA~~ [ana6, com8]: Add ana6Optimisation Module, apply changes in com8MoTPSA Feb 24, 2026

RolandFischbacher force-pushed the RF_com8MoTPSA branch from f66f702 to 38e42ca Compare February 24, 2026 08:50

qltysh bot reviewed Feb 24, 2026

View reviewed changes

fso42 assigned fso42 and unassigned RolandFischbacher Feb 24, 2026

fso42 force-pushed the RF_com8MoTPSA branch from 38e42ca to 15f5438 Compare February 24, 2026 14:35

qltysh bot reviewed Feb 24, 2026

View reviewed changes

avaframe/ana6Optimisation/optimisationUtils.py Show resolved Hide resolved

avaframe/ana6Optimisation/optimisationUtils.py Outdated Show resolved Hide resolved

avaframe/com8MoTPSA/com8MoTPSA.py Outdated Show resolved Hide resolved

avaframe/com8MoTPSA/com8MoTPSA.py Show resolved Hide resolved

fso42 assigned RolandFischbacher and unassigned fso42 Feb 24, 2026

RolandFischbacher commented Feb 24, 2026

View reviewed changes

avaframe/runScripts/runPlotAreaRefDiffs.py Outdated Show resolved Hide resolved

refactor(runScripts): runPlotAreaRefDiffs,removing unused condition…

e41ff1c

…s and checks

qltysh bot reviewed Feb 26, 2026

View reviewed changes

avaframe/out3Plot/outAna6Plots.py Outdated Show resolved Hide resolved

RolandFischbacher added 2 commits February 26, 2026 09:43

fix(probAna): restore missing bounds and config writing after merge

a7f0a5e

- Add bounds to paramValuesD in createSamplesWithVariation (StandardParameters) - Add writing of visualisation scenario and sampling method to com8MoTPSACfg.ini

Merge remote-tracking branch 'origin/RF_com8MoTPSA' into RF_com8MoTPSA

3f4d1e5

qltysh bot reviewed Feb 26, 2026

View reviewed changes

avaframe/out3Plot/outAna6Plots.py Show resolved Hide resolved

fix: handle new _L1/_L2 naming in merging logic and rename some varia…

97fd380

…bles

qltysh bot reviewed Feb 26, 2026

View reviewed changes

avaframe/out3Plot/outAna6Plots.py Show resolved Hide resolved

avaframe/out3Plot/outAna6Plots.py Show resolved Hide resolved

fso42 requested changes Feb 26, 2026

View reviewed changes

OpenNHM deleted a comment from qltysh bot Feb 27, 2026

RolandFischbacher added 8 commits February 28, 2026 13:44

change function name, move parameter to ini file, change values of in…

7c32be0

…i file, delete redundant code

Add: if __name__ == '__main__'

81b2d68

Fix: remove duplicate in com8MoTPSAMain and read chunkSize from avafr…

76b0dc8

…ameCfg.ini nCPU

Implement a direct call of com8MoTPSAMain with updated cfgs (writeCfg…

3d831a7

…Files in optimisationUtils.py), add possibility to RUN writeCfgFiles with counter

Use logging instead of print in optimisationUtils.py

8843c22

Add sklearn (scikit-learn) to the requirements in pyproject.toml and …

51ac8a1

…clean header Implement modName to make code general and remove adjustText package

Initialize index and sampleMethod with np.nan to avoid UnboundLocalEr…

0f4e968

…ror and stale values and remove copy paste error.

Add a check if 'VISUALISATION' exists in cfgStart, if not, it will be…

4d36ca4

… added to cfgStart. And read sample method with fallback; meaning if 'PROBANA' or 'sampleMethod' is missing sample_method contains an empty string

qltysh bot reviewed Feb 28, 2026

View reviewed changes

Make optimisationType case-insensitive, add raise ValueErrors, update…

0e7b446

… docstring, tidy up code, add if __name__='__main__': in runPlotMorrisConvergence.py and improve BOConvergencePlot.

qltysh bot reviewed Mar 2, 2026

View reviewed changes

		return xBest, xBestDict, np.max(ei), np.max(lcb)


		def runCom8MoTPSA(avalancheDir, xBestDict, cfgMain, i=0, optimisationType=None):

	results = pool.map(com8MoTPSATask, rcfFilesChunk)
	pool.map(com8MoTPSATask, rcfFilesChunk)

Conversation

RolandFischbacher commented Feb 23, 2026

The module ana6Optimisation includes:

Changed workflow of runing com8MoTPSA:

Uh oh!

qltysh bot commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot Feb 23, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

qltysh bot commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

RolandFischbacher Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

qltysh bot Feb 28, 2026

Choose a reason for hiding this comment

Uh oh!

qltysh bot commented Feb 23, 2026 •

edited

Loading

qltysh bot commented Feb 24, 2026 •

edited

Loading

RolandFischbacher Feb 28, 2026 •

edited

Loading