Add ThermoPower branch v4.0.0-dev to the CI#280
Merged
AndreaBartolini merged 5 commits intoOpenModelica:masterfrom Mar 26, 2026
Merged
Add ThermoPower branch v4.0.0-dev to the CI#280AndreaBartolini merged 5 commits intoOpenModelica:masterfrom
AndreaBartolini merged 5 commits intoOpenModelica:masterfrom
Conversation
AnHeuermann
reviewed
Mar 26, 2026
.CI/installLibraries.mos
Outdated
| {"ThermofluidStream", ""}, | ||
| {"ThermofluidStream", "main"}, | ||
| {"ThermoPower", "master"}, | ||
| {"ThermoPower", "v4.0.0-dev"}, |
Member
There was a problem hiding this comment.
I think the branch provides version v4.0.0 without the dev part, see
https://github.com/casella/ThermoPower/blob/v4.0.0-dev/ThermoPower%204.0.0/package.mo#L2124.
Contributor
Author
There was a problem hiding this comment.
you are right... I've accepted your changes
Member
There was a problem hiding this comment.
Suggested change
| {"ThermoPower", "v4.0.0-dev"}, | |
| {"ThermoPower", "4.0.0-dev"}, |
My bad, I looked at the actual JSON and it should be this one.
Co-authored-by: Andreas <38031952+AnHeuermann@users.noreply.github.com>
Member
|
Oh it is actually the |
Contributor
Author
|
In the git repo the branch is v4.0.0-dev, inside the package.mo file the version is 4.0.0 |
Member
|
Okay, looking at what get's resolved by Jenkins in OpenModelica/OMPackageManager@3dbba6d it should be "version": "4.0.0-dev"Sorry for the confusion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new release v.0.0-dev of the ThermoPower library has been added to the CI in order to check the possible regressions before to the officially release.