chore: remove INSTALL_BOTO3 and INSTALL_ACP build args#2570
Closed
simonrosenberg wants to merge 1 commit intomainfrom
Closed
chore: remove INSTALL_BOTO3 and INSTALL_ACP build args#2570simonrosenberg wants to merge 1 commit intomainfrom
simonrosenberg wants to merge 1 commit intomainfrom
Conversation
…ll all deps All images now unconditionally include boto3 and ACP deps. The conditional ARGs added unnecessary complexity for negligible size savings. Closes #2569 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Python API breakage checks — ✅ PASSEDResult: ✅ PASSED |
Contributor
REST API breakage checks (OpenAPI) — ✅ PASSEDResult: ✅ PASSED |
all-hands-bot
approved these changes
Mar 25, 2026
Collaborator
all-hands-bot
left a comment
There was a problem hiding this comment.
🟢 Good taste - Clean simplification that removes unnecessary conditional complexity. The defaults were already true, so this just eliminates the option to disable boto3/ACP, making builds more predictable. LGTM!
3 tasks
Collaborator
Author
|
Closing since it's a duplicate of #2608 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ARG INSTALL_BOTO3from Dockerfile — always install theboto3extraARG INSTALL_ACPfrom Dockerfile — always install ACP serversINSTALL_ACPexample inBuildOptions.extra_build_argsdescriptionAll images now unconditionally include boto3 and ACP deps. The conditional ARGs added unnecessary complexity for negligible size savings.
Closes #2569
Test plan
🤖 Generated with Claude Code
Agent Server images for this PR
• GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server
Variants & Base Images
eclipse-temurin:17-jdknikolaik/python-nodejs:python3.13-nodejs22golang:1.21-bookwormPull (multi-arch manifest)
# Each variant is a multi-arch manifest supporting both amd64 and arm64 docker pull ghcr.io/openhands/agent-server:16ad7b5-pythonRun
All tags pushed for this build
About Multi-Architecture Support
16ad7b5-python) is a multi-arch manifest supporting both amd64 and arm6416ad7b5-python-amd64) are also available if needed