Skip to content

chore: remove INSTALL_BOTO3 and INSTALL_ACP build args#2570

Closed
simonrosenberg wants to merge 1 commit intomainfrom
chore/remove-install-build-args
Closed

chore: remove INSTALL_BOTO3 and INSTALL_ACP build args#2570
simonrosenberg wants to merge 1 commit intomainfrom
chore/remove-install-build-args

Conversation

@simonrosenberg
Copy link
Copy Markdown
Collaborator

@simonrosenberg simonrosenberg commented Mar 25, 2026

Summary

  • Remove ARG INSTALL_BOTO3 from Dockerfile — always install the boto3 extra
  • Remove ARG INSTALL_ACP from Dockerfile — always install ACP servers
  • Clean up stale INSTALL_ACP example in BuildOptions.extra_build_args description

All images now unconditionally include boto3 and ACP deps. The conditional ARGs added unnecessary complexity for negligible size savings.

Closes #2569

Test plan

  • CI builds the Docker image successfully without the removed ARGs
  • Benchmark images include boto3 and ACP deps as expected

🤖 Generated with Claude Code


Agent Server images for this PR

GHCR package: https://github.com/OpenHands/agent-sdk/pkgs/container/agent-server

Variants & Base Images

Variant Architectures Base Image Docs / Tags
java amd64, arm64 eclipse-temurin:17-jdk Link
python amd64, arm64 nikolaik/python-nodejs:python3.13-nodejs22 Link
golang amd64, arm64 golang:1.21-bookworm Link

Pull (multi-arch manifest)

# Each variant is a multi-arch manifest supporting both amd64 and arm64
docker pull ghcr.io/openhands/agent-server:16ad7b5-python

Run

docker run -it --rm \
  -p 8000:8000 \
  --name agent-server-16ad7b5-python \
  ghcr.io/openhands/agent-server:16ad7b5-python

All tags pushed for this build

ghcr.io/openhands/agent-server:16ad7b5-golang-amd64
ghcr.io/openhands/agent-server:16ad7b5-golang_tag_1.21-bookworm-amd64
ghcr.io/openhands/agent-server:16ad7b5-golang-arm64
ghcr.io/openhands/agent-server:16ad7b5-golang_tag_1.21-bookworm-arm64
ghcr.io/openhands/agent-server:16ad7b5-java-amd64
ghcr.io/openhands/agent-server:16ad7b5-eclipse-temurin_tag_17-jdk-amd64
ghcr.io/openhands/agent-server:16ad7b5-java-arm64
ghcr.io/openhands/agent-server:16ad7b5-eclipse-temurin_tag_17-jdk-arm64
ghcr.io/openhands/agent-server:16ad7b5-python-amd64
ghcr.io/openhands/agent-server:16ad7b5-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-amd64
ghcr.io/openhands/agent-server:16ad7b5-python-arm64
ghcr.io/openhands/agent-server:16ad7b5-nikolaik_s_python-nodejs_tag_python3.13-nodejs22-arm64
ghcr.io/openhands/agent-server:16ad7b5-golang
ghcr.io/openhands/agent-server:16ad7b5-java
ghcr.io/openhands/agent-server:16ad7b5-python

About Multi-Architecture Support

  • Each variant tag (e.g., 16ad7b5-python) is a multi-arch manifest supporting both amd64 and arm64
  • Docker automatically pulls the correct architecture for your platform
  • Individual architecture tags (e.g., 16ad7b5-python-amd64) are also available if needed

…ll all deps

All images now unconditionally include boto3 and ACP deps.
The conditional ARGs added unnecessary complexity for negligible size savings.

Closes #2569

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown
Contributor

Python API breakage checks — ✅ PASSED

Result:PASSED

Action log

@github-actions
Copy link
Copy Markdown
Contributor

REST API breakage checks (OpenAPI) — ✅ PASSED

Result:PASSED

Action log

Copy link
Copy Markdown
Collaborator

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Clean simplification that removes unnecessary conditional complexity. The defaults were already true, so this just eliminates the option to disable boto3/ACP, making builds more predictable. LGTM!

@simonrosenberg
Copy link
Copy Markdown
Collaborator Author

simonrosenberg commented Mar 30, 2026

Closing since it's a duplicate of #2608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: remove INSTALL_BOTO3 build arg — all images can include it

2 participants